Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2119433002: Convert "ios_packed_resources" gyp target to gn. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org, Eugene But (OOO till 7-30)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert "ios_packed_resources" gyp target to gn. This target was overlooked and will be used by refactoring of ios_chrome_unittests. BUG=624450 Committed: https://crrev.com/81c9ff1602706f86f8304226d3c2ab85ebee115a Cr-Commit-Position: refs/heads/master@{#403159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -0 lines) Patch
M ios/chrome/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/app/resources/BUILD.gn View 2 chunks +45 lines, -0 lines 0 comments Download
A ios/chrome/app/resources/ios_chrome_repack.gni View 1 chunk +230 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome_resources.gyp View 8 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
Please take a look and send to CQ if LGTY. eugenebut: FYI
4 years, 5 months ago (2016-06-30 11:52:18 UTC) #2
rohitrao (ping after 24h)
lgtm Rubberstamp LGTM Overall structure looks fine. Is there anyone else who would be a ...
4 years, 5 months ago (2016-06-30 12:56:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119433002/1
4 years, 5 months ago (2016-06-30 12:56:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 13:00:37 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/81c9ff1602706f86f8304226d3c2ab85ebee115a Cr-Commit-Position: refs/heads/master@{#403159}
4 years, 5 months ago (2016-06-30 13:02:30 UTC) #8
sdefresne
4 years, 5 months ago (2016-06-30 14:37:38 UTC) #9
Message was sent while issue was closed.
On 2016/06/30 12:56:11, rohitrao wrote:
> lgtm
> 
> Rubberstamp LGTM
> 
> Overall structure looks fine.  Is there anyone else who would be a better
> reviewer for the GN code itself?

Maybe dpranke or brettw but they are a bit overcharged currently.

Powered by Google App Engine
This is Rietveld 408576698