src/promise.js - Issue 211943004: Promise constructor should not be enumerable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/promise.js

Issue 211943004: Promise constructor should not be enumerable. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/promise.js

diff --git a/src/promise.js b/src/promise.js

index 23e51259a36c43849002990ea2b3ebbb3c5c0105..a22c46e4744b9746041c9e89ec14647be9e62bcc 100644

--- a/src/promise.js

+++ b/src/promise.js

@@ -308,7 +308,11 @@ function PromiseOne(values) {

function SetUpPromise() {

%CheckIsBootstrapping()

var global_receiver = %GlobalReceiver(global);

- global_receiver.Promise = $Promise;

+ $Object.defineProperty(global_receiver, 'Promise', {

rossberg 2014/03/26 09:59:37 You can use %SetProperty directly, like I did in t

yhirano 2014/03/26 10:09:12 Thanks, done.

+ value: $Promise,

+ writable: true,

+ configurable: true

+ });

InstallFunctions($Promise, DONT_ENUM, [

"defer", PromiseDeferred,

"accept", PromiseResolved,

« no previous file with comments | « no previous file | no next file » | no next file with comments »