Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 211943004: Promise constructor should not be enumerable. (Closed)

Created:
6 years, 9 months ago by yhirano
Modified:
6 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Visibility:
Public.

Description

Promise constructor should not be enumerable. Promise should not be enumerable in the global object. BUG=352597 R=rossberg@chromium.org LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=20268

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/promise.js View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yhirano
PTAL This fixes webexposed/ layout tests in blink, so it should be landed and rolled ...
6 years, 9 months ago (2014-03-26 02:28:19 UTC) #1
rossberg
https://codereview.chromium.org/211943004/diff/1/src/promise.js File src/promise.js (right): https://codereview.chromium.org/211943004/diff/1/src/promise.js#newcode311 src/promise.js:311: $Object.defineProperty(global_receiver, 'Promise', { You can use %SetProperty directly, like ...
6 years, 9 months ago (2014-03-26 09:59:37 UTC) #2
yhirano
https://codereview.chromium.org/211943004/diff/1/src/promise.js File src/promise.js (right): https://codereview.chromium.org/211943004/diff/1/src/promise.js#newcode311 src/promise.js:311: $Object.defineProperty(global_receiver, 'Promise', { On 2014/03/26 09:59:37, rossberg wrote: > ...
6 years, 9 months ago (2014-03-26 10:09:11 UTC) #3
rossberg
lgtm
6 years, 9 months ago (2014-03-26 10:11:45 UTC) #4
rossberg
6 years, 9 months ago (2014-03-26 10:14:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698