[webcrypto] Minor cleanup/consolidation of JWK source.

[webcrypto] Minor cleanup/consolidation of JWK source.

BUG=245025
TEST=content_unittests --gtest_filter="SharedCryptoTest*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259536

[padolph, 2014-03-25 23:30:11]

Getting rid a few TODO's related to JWK.

[eroman, 2014-03-25 23:35:50]

What do you mean by "Patched from 205913002" in description? If that is
referring to this CL forking from that branch, then please remove that from
description

[padolph, 2014-03-25 23:42:49]

I branched from master, and then did 'git cl patch 205913002'. To
avoid changes from 205913002 showing up in the upload, I did 'git cl
upload HEAD~'. Xiaohan Wang at Google advised me to do things this way
and also be explicit in the comment so the diffs are clear.

I always remove the "Patched from XXX" from the description once the
other CL lands and I rebase. I can remove it now but then I'm afraid
the diffs don't make as much sense. In this case they are mostly
(completely?) nonoverlapping, so not as big a deal.


On Tue, Mar 25, 2014 at 4:35 PM,  <eroman@chromium.org> wrote:
> What do you mean by "Patched from 205913002" in description? If that is
> referring to this CL forking from that branch, then please remove that from
> description
>
> https://codereview.chromium.org/211943002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[eroman, 2014-03-25 23:43:36]

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/jwk.h
File content/child/webcrypto/jwk.h (right):

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/jwk....
content/child/webcrypto/jwk.h:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
This file should also be added to the .gypi.

That will require owners approval however, and could be done as a follow-up
step.

My suggestion is to add it to this changelist.

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/jwk....
content/child/webcrypto/jwk.h:17: 
nit: delete this empty line

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/shar...
File content/child/webcrypto/shared_crypto.cc (right):

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/shar...
content/child/webcrypto/shared_crypto.cc:13: #include "jwk.h"
use a full path:
"content/child/webcrypto/jwk.h"

[padolph, 2014-03-26 00:01:46]

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/jwk.h
File content/child/webcrypto/jwk.h (right):

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/jwk....
content/child/webcrypto/jwk.h:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
On 2014/03/25 23:43:37, eroman wrote:
> This file should also be added to the .gypi.
> 
> That will require owners approval however, and could be done as a follow-up
> step.
> 
> My suggestion is to add it to this changelist.

Done.

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/jwk....
content/child/webcrypto/jwk.h:17: 
On 2014/03/25 23:43:37, eroman wrote:
> nit: delete this empty line

Done.

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/shar...
File content/child/webcrypto/shared_crypto.cc (right):

https://codereview.chromium.org/211943002/diff/1/content/child/webcrypto/shar...
content/child/webcrypto/shared_crypto.cc:13: #include "jwk.h"
On 2014/03/25 23:43:37, eroman wrote:
> use a full path:
> "content/child/webcrypto/jwk.h"

Oops, sorry. Done.

[padolph, 2014-03-26 00:02:25]

Note: This CL is based on CL 205913002.

[eroman, 2014-03-26 00:10:37]

Patchset 2 LGTM

avi or brettw: Could you approve the trivial changes to content_child.gypi:

https://codereview.chromium.org/211943002/diff/80001/content/content_child.gy...

Thanks!

https://codereview.chromium.org/211943002/diff/80001/content/child/webcrypto/...
File content/child/webcrypto/shared_crypto.h (left):

https://codereview.chromium.org/211943002/diff/80001/content/child/webcrypto/...
content/child/webcrypto/shared_crypto.h:20: 
hah! you were just copy pasting my mistake :)

[eroman, 2014-03-26 00:11:07]

avi or brettw: Could you approve the trivial changes to content_child.gypi:

https://codereview.chromium.org/211943002/diff/80001/content/content_child.gy...

Thanks!

[Avi (use Gerrit), 2014-03-26 02:12:57]

LGTM

[eroman, 2014-03-26 02:13:36]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-03-26 02:13:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/padolph@netflix.com/211943002/80001

[commit-bot: I haz the power, 2014-03-26 04:54:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 04:54:32]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[padolph, 2014-03-26 07:36:16]

The CQ bit was checked by padolph@netflix.com

[commit-bot: I haz the power, 2014-03-26 07:36:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/padolph@netflix.com/211943002/80001

[commit-bot: I haz the power, 2014-03-26 09:50:59]

Change committed as 259536