ui/views/view.cc - Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view.cc

Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactor to use ui::AX_ROLE_IGNORED for excluding a11y elements from the tree instead of focusabili… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/accessibility/native_view_accessibility_win_unittest.cc ('K') | « ui/views/view.h ('k') | ui/views/widget/native_widget_mac_accessibility_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/view.cc

diff --git a/ui/views/view.cc b/ui/views/view.cc

index 92223157d4c8671aaa2c55aab4c006d1ee25b265..26d258f589ab8dbc610978aeb83b374431e193a6 100644

--- a/ui/views/view.cc

+++ b/ui/views/view.cc

@@ -1339,10 +1339,10 @@ bool View::HandleAccessibleAction(const ui::AXActionData& action_data) {

gfx::NativeViewAccessible View::GetNativeViewAccessible() {

if (!native_view_accessibility_)

- native_view_accessibility_ = NativeViewAccessibility::Create(this);

+ native_view_accessibility_ = NativeViewAccessibility::GetOrCreate(this);

if (native_view_accessibility_)

return native_view_accessibility_->GetNativeObject();

- return NULL;

+ return nullptr;

}

void View::NotifyAccessibilityEvent(

@@ -1353,7 +1353,7 @@ void View::NotifyAccessibilityEvent(

if (send_native_event && GetWidget()) {

if (!native_view_accessibility_)

- native_view_accessibility_ = NativeViewAccessibility::Create(this);

+ native_view_accessibility_ = NativeViewAccessibility::GetOrCreate(this);

if (native_view_accessibility_)

native_view_accessibility_->NotifyAccessibilityEvent(event_type);

}