ui/accessibility/platform/ax_platform_node_mac.mm - Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/accessibility/platform/ax_platform_node_mac.mm

Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactor to use ui::AX_ROLE_IGNORED for excluding a11y elements from the tree instead of focusabili… Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/accessibility/platform/ax_platform_node_mac.mm

diff --git a/ui/accessibility/platform/ax_platform_node_mac.mm b/ui/accessibility/platform/ax_platform_node_mac.mm

index b06cb439dfc32467381b54aaa1d3a25868ed1589..ec303d88cf0f7a97f883c4632653a395196d801f 100644

--- a/ui/accessibility/platform/ax_platform_node_mac.mm

+++ b/ui/accessibility/platform/ax_platform_node_mac.mm

@@ -285,7 +285,8 @@ void NotifyMacEvent(AXPlatformNodeCocoa* target, ui::AXEvent event_type) {

- (id)accessibilityHitTest:(NSPoint)point {

for (AXPlatformNodeCocoa* child in [self AXChildren]) {

- if (NSPointInRect(point, child.boundsInScreen))

+ if (NSPointInRect(point, [child boundsInScreen]) &&

+ ![child accessibilityIsIgnored])

tapted 2016/12/22 02:56:36 nit: reorder these so accessibilityIsIgnored is ch

Patti Lor 2017/01/11 02:01:47 Done.

return [child accessibilityHitTest:point];

}

return NSAccessibilityUnignoredAncestor(self);

« no previous file with comments | « no previous file | ui/views/accessibility/native_view_accessibility.h » ('j') | ui/views/accessibility/native_view_accessibility.h » ('J')