Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: ui/views/accessibility/native_view_accessibility.h

Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to a Mac-specific approach by ignoring elements with keyboard focusable parents. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/accessibility/native_view_accessibility.h
diff --git a/ui/views/accessibility/native_view_accessibility.h b/ui/views/accessibility/native_view_accessibility.h
index f4d61b3f87919fc25799dea2ae7c171ad2c9af63..abeedd54aead2eaa3748294590ec231a0f5d5858 100644
--- a/ui/views/accessibility/native_view_accessibility.h
+++ b/ui/views/accessibility/native_view_accessibility.h
@@ -49,7 +49,12 @@ class VIEWS_EXPORT NativeViewAccessibility
// Focuses or unfocuses a View.
bool SetFocused(bool focused);
- // ui::AXPlatformNodeDelegate
+#if defined(OS_MACOSX)
+ // Checks if there are any keyboard focusable ancestors.
+ bool HasFocusableAncestor();
tapted 2016/11/25 04:36:27 can this be moved to an anonymous namespace in the
Patti Lor 2016/11/28 06:40:23 Good idea, thanks! I actually realised that just u
+#endif
+
+ // ui::AXPlatformNodeDelegate:
const ui::AXNodeData& GetData() override;
int GetChildCount() override;
gfx::NativeViewAccessible ChildAtIndex(int index) override;
@@ -62,7 +67,7 @@ class VIEWS_EXPORT NativeViewAccessibility
bool AccessibilityPerformAction(const ui::AXActionData& data) override;
void DoDefaultAction() override;
- // WidgetObserver
+ // WidgetObserver:
void OnWidgetDestroying(Widget* widget) override;
Widget* parent_widget() const { return parent_widget_; }

Powered by Google App Engine
This is Rietveld 408576698