ui/accessibility/platform/ax_platform_node_win.cc - Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/accessibility/platform/ax_platform_node_win.cc

Issue 2119413004: a11y: Exclude children of nested keyboard accessible controls from a11y tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Linting & review comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/accessibility/platform/ax_platform_node_win.cc

diff --git a/ui/accessibility/platform/ax_platform_node_win.cc b/ui/accessibility/platform/ax_platform_node_win.cc

index 43dc94dd6c0b9c7bb2b87c1a543f4bef7938e40f..bd4322f5bfa72fcf69bc5a1957dedcecaf406480 100644

--- a/ui/accessibility/platform/ax_platform_node_win.cc

+++ b/ui/accessibility/platform/ax_platform_node_win.cc

@@ -1118,8 +1118,10 @@ int AXPlatformNodeWin::MSAAState() {

msaa_state |= STATE_SYSTEM_HASPOPUP;

if (state & (1 << ui::AX_STATE_HOVERED))

msaa_state |= STATE_SYSTEM_HOTTRACKED;

- if (state & (1 << ui::AX_STATE_INVISIBLE))

+ if (state & (1 << ui::AX_STATE_INVISIBLE) ||

+ GetData().role == ui::AX_ROLE_IGNORED) {

msaa_state |= STATE_SYSTEM_INVISIBLE;

+ }

if (state & (1 << ui::AX_STATE_LINKED))

msaa_state |= STATE_SYSTEM_LINKED;

if (state & (1 << ui::AX_STATE_OFFSCREEN))

« no previous file with comments | « ui/accessibility/platform/ax_platform_node_mac.mm ('k') | ui/views/accessibility/native_view_accessibility_base.cc » ('j') | no next file with comments »