a11y: Exclude children of nested keyboard accessible controls from a11y tree.

ui/views/widget/native_widget_mac_accessibility_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #import "testing/gtest_mac.h"
 #include "ui/accessibility/ax_enums.h"
 #include "ui/accessibility/ax_view_state.h"
 #import "ui/accessibility/platform/ax_platform_node_mac.h"
 #include "ui/base/ime/text_input_type.h"
 #import "ui/gfx/mac/coordinate_conversion.h"
+#include "ui/views/accessibility/native_view_accessibility.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/test/widget_test.h"
 #include "ui/views/widget/widget.h"
 
 // Expose some methods from AXPlatformNodeCocoa for testing purposes only.
 @interface AXPlatformNodeCocoa (Testing)
 - (NSString*)AXRole;
 @end
 
 namespace views {
 
 namespace {
 
 NSString* const kTestPlaceholderText = @"Test placeholder text";
 NSString* const kTestStringValue = @"Test string value";
 NSString* const kTestTitle = @"Test textfield";
 
 class FlexibleRoleTestView : public View {
  public:
-  explicit FlexibleRoleTestView(ui::AXRole role) : role_(role) {}
+  explicit FlexibleRoleTestView(ui::AXRole role) : role_(role) {
+    SetFocusBehavior(FocusBehavior::ACCESSIBLE_ONLY);
+  }
+
   void set_role(ui::AXRole role) { role_ = role; }
 
   // Add a child view and resize to fit the child.
   void FitBoundsToNewChild(View* view) {
     View::AddChildView(view);
     // Fit the parent widget to the size of the child for accurate hit tests.
     SetBoundsRect(view->bounds());
   }
 
   // View:
@@ skipping 56 matching lines @@
 
 // Test for NSAccessibilityChildrenAttribute, and ensure it excludes ignored
 // children from the accessibility tree.
 TEST_F(NativeWidgetMacAccessibilityTest, ChildrenAttribute) {
   // Check childless views don't have accessibility children.
   EXPECT_EQ(0u,
             [AttributeValueAtMidpoint(NSAccessibilityChildrenAttribute) count]);
 
   const size_t kNumChildren = 3;
   for (size_t i = 0; i < kNumChildren; ++i) {
-    // Make sure the labels won't interfere with the hit test.
+    // Add children sized 0x0 to ensure they won't interfere with the hit tests.
     AddChildTextfield(gfx::Size());
   }
 
   EXPECT_EQ(kNumChildren,
             [AttributeValueAtMidpoint(NSAccessibilityChildrenAttribute) count]);
 
   // Check ignored children don't show up in the accessibility tree.
   widget()->GetContentsView()->AddChildView(
       new FlexibleRoleTestView(ui::AX_ROLE_IGNORED));
   EXPECT_EQ(kNumChildren,
             [AttributeValueAtMidpoint(NSAccessibilityChildrenAttribute) count]);
 }
 
 // Test for NSAccessibilityParentAttribute, including for a Widget with no
 // parent.
 TEST_F(NativeWidgetMacAccessibilityTest, ParentAttribute) {
   Textfield* child = AddChildTextfield(widget()->GetContentsView()->size());
 
-  // Views with Widget parents will have a NSWindow parent.
-  EXPECT_NSEQ(
-      NSAccessibilityWindowRole,
-      [AttributeValueAtMidpoint(NSAccessibilityParentAttribute) AXRole]);
+  // Views with Widget parents will have a RootView (BridgedContentView) parent,
+  // which doesn't use the legacy NSAccessibility Informal Protocol Reference,
+  // so retrieve the AXRole via accessibilityAttributeValue instead.
+  EXPECT_NSEQ(NSAccessibilityWindowRole,
+              [AttributeValueAtMidpoint(NSAccessibilityParentAttribute)
+                  accessibilityAttributeValue:NSAccessibilityRoleAttribute]);
 
-  // Views with non-Widget parents will have the role of the parent view.
+  // Children of other Views will report their View parent's role.
   widget()->GetContentsView()->RemoveChildView(child);
   FlexibleRoleTestView* parent = new FlexibleRoleTestView(ui::AX_ROLE_GROUP);
   parent->FitBoundsToNewChild(child);
   widget()->GetContentsView()->AddChildView(parent);
   EXPECT_NSEQ(
       NSAccessibilityGroupRole,
       [AttributeValueAtMidpoint(NSAccessibilityParentAttribute) AXRole]);
 
   // Test an ignored role parent is skipped in favor of the grandparent.
   parent->set_role(ui::AX_ROLE_IGNORED);
-  EXPECT_NSEQ(
-      NSAccessibilityWindowRole,
-      [AttributeValueAtMidpoint(NSAccessibilityParentAttribute) AXRole]);
+  EXPECT_NSEQ(NSAccessibilityWindowRole,
+              [AttributeValueAtMidpoint(NSAccessibilityParentAttribute)
+                  accessibilityAttributeValue:NSAccessibilityRoleAttribute]);
 }
 
 // Test for NSAccessibilityPositionAttribute, including on Widget movement
 // updates.
 TEST_F(NativeWidgetMacAccessibilityTest, PositionAttribute) {
   NSValue* widget_origin =
       [NSValue valueWithPoint:gfx::ScreenPointToNSPoint(
                                   GetWidgetBounds().bottom_left())];
   EXPECT_NSEQ(widget_origin,
               AttributeValueAtMidpoint(NSAccessibilityPositionAttribute));
 
   // Check the attribute is updated when the Widget is moved.
   gfx::Rect new_bounds(60, 80, 100, 100);
   widget()->SetBounds(new_bounds);
   widget_origin = [NSValue
       valueWithPoint:gfx::ScreenPointToNSPoint(new_bounds.bottom_left())];
   EXPECT_NSEQ(widget_origin,
               AttributeValueAtMidpoint(NSAccessibilityPositionAttribute));
+
+  // Check the attribute is correct for a View.
+  Textfield* textfield = AddChildTextfield(gfx::Size(70, 70));
+  widget_origin = [NSValue
+      valueWithPoint:gfx::ScreenPointToNSPoint(
+                         textfield->GetBoundsInScreen().bottom_left())];
+  EXPECT_NSEQ(NSAccessibilityTextFieldRole,
+              AttributeValueAtMidpoint(NSAccessibilityRoleAttribute));
+  EXPECT_NSEQ(widget_origin,
+              AttributeValueAtMidpoint(NSAccessibilityPositionAttribute));
 }
 
 // Test for NSAccessibilityHelpAttribute.
 TEST_F(NativeWidgetMacAccessibilityTest, HelpAttribute) {
   Label* label = new Label(base::SysNSStringToUTF16(kTestPlaceholderText));
+  label->SetFocusBehavior(ClientView::FocusBehavior::ACCESSIBLE_ONLY);
   label->SetSize(GetWidgetBounds().size());
   EXPECT_NSEQ(nil, AttributeValueAtMidpoint(NSAccessibilityHelpAttribute));
   label->SetTooltipText(base::SysNSStringToUTF16(kTestPlaceholderText));
   widget()->GetContentsView()->AddChildView(label);
   EXPECT_NSEQ(kTestPlaceholderText,
               AttributeValueAtMidpoint(NSAccessibilityHelpAttribute));
 }
 
 // Test for NSAccessibilityWindowAttribute and
 // NSAccessibilityTopLevelUIElementAttribute.
@@ skipping 12 matching lines @@
 }
 
 // Tests for accessibility attributes on a views::Textfield.
 // TODO(patricialor): Test against Cocoa-provided attributes as well to ensure
 // consistency between Cocoa and toolkit-views.
 TEST_F(NativeWidgetMacAccessibilityTest, TextfieldGenericAttributes) {
   Textfield* textfield = AddChildTextfield(GetWidgetBounds().size());
 
   // NSAccessibilityEnabledAttribute.
   textfield->SetEnabled(false);
+  // Disabled items should be unfocusable but shouldn't be ignored.
+  EXPECT_FALSE(textfield->IsAccessibilityFocusable());
+  EXPECT_FALSE(textfield->GetNativeViewAccessibility()->IsIgnored());
   EXPECT_EQ(NO, [AttributeValueAtMidpoint(NSAccessibilityEnabledAttribute)
                     boolValue]);
   textfield->SetEnabled(true);
   EXPECT_EQ(YES, [AttributeValueAtMidpoint(NSAccessibilityEnabledAttribute)
                      boolValue]);
 
   // NSAccessibilityFocusedAttribute.
   EXPECT_EQ(NO, [AttributeValueAtMidpoint(NSAccessibilityFocusedAttribute)
                     boolValue]);
   textfield->RequestFocus();
@@ skipping 115 matching lines @@
   EXPECT_FALSE(
       [ax_node accessibilityIsAttributeSettable:NSAccessibilityValueAttribute]);
   [ax_node accessibilitySetValue:kTestStringValue
                     forAttribute:NSAccessibilityValueAttribute];
   EXPECT_NSEQ(kTestPlaceholderText,
               AttributeValueAtMidpoint(NSAccessibilityValueAttribute));
   EXPECT_EQ(base::SysNSStringToUTF16(kTestPlaceholderText), textfield->text());
 }
 
 }  // namespace views