a11y: Exclude children of nested keyboard accessible controls from a11y tree.

ui/views/accessibility/native_view_accessibility.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event_utils.h"
@@ skipping 71 matching lines @@
   if (!view_->enabled())
     data_.state |= (1 << ui::AX_STATE_DISABLED);
 
   if (!view_->visible())
     data_.state |= (1 << ui::AX_STATE_INVISIBLE);
 
   return data_;
 }
 
 int NativeViewAccessibility::GetChildCount() {
-  int child_count = view_->child_count();
+  int child_count = 0;
+  for (int i = 0; i < view_->child_count(); ++i) {
+    View* child = view_->child_at(i);
+    if (child->GetNativeViewAccessibility()->IsIgnored()) {
+      // If not visible to accessibility clients, then use the children instead.
+      child_count += child->GetNativeViewAccessibility()->GetChildCount();
+    } else {
+      ++child_count;
+    }
+  }
 
   std::vector<Widget*> child_widgets;
   PopulateChildWidgetVector(&child_widgets);
   child_count += child_widgets.size();
 
   return child_count;
 }
 
 gfx::NativeViewAccessible NativeViewAccessibility::ChildAtIndex(int index) {
-  // If this is a root view, our widget might have child widgets. Include
+  if (IsLeafElement())
+    return nullptr;
+
+  // Include the child widgets that may be present if this is a root view.
   std::vector<Widget*> child_widgets;
   PopulateChildWidgetVector(&child_widgets);
   int child_widget_count = static_cast<int>(child_widgets.size());
 
-  if (index < view_->child_count()) {
-    return view_->child_at(index)->GetNativeViewAccessible();
-  } else if (index < view_->child_count() + child_widget_count) {
+  int ax_child_count = GetChildCount();
+  if (index < ax_child_count) {
+    int curr_child_count = 0;
+    for (int i = 0; i < view_->child_count(); ++i) {
+      View* child = view_->child_at(i);
+      bool ignored = child->GetNativeViewAccessibility()->IsIgnored();
+      int pending_children =
+          ignored ? child->GetNativeViewAccessibility()->GetChildCount() : 1;
+      if (index < curr_child_count + pending_children) {
+        if (ignored) {
+          return child->GetNativeViewAccessibility()->ChildAtIndex(
+              index - curr_child_count);
+        }
+        return child->GetNativeViewAccessible();
+      }
+      curr_child_count += pending_children;
+    }
+  } else if (index < ax_child_count + child_widget_count) {
     Widget* child_widget = child_widgets[index - view_->child_count()];
     return child_widget->GetRootView()->GetNativeViewAccessible();
   }
 
   return nullptr;
 }
 
 gfx::NativeWindow NativeViewAccessibility::GetTopLevelWidget() {
   if (view_->GetWidget())
     return view_->GetWidget()->GetTopLevelWidget()->GetNativeWindow();
   return nullptr;
 }
 
 gfx::NativeViewAccessible NativeViewAccessibility::GetParent() {
-  if (view_->parent())
-    return view_->parent()->GetNativeViewAccessible();
+  View* parent_view = view_->parent();
+  if (parent_view) {
+    if (parent_view->GetNativeViewAccessibility()->IsIgnored())
+      return parent_view->GetNativeViewAccessibility()->GetParent();
+    else
+      return parent_view->GetNativeViewAccessible();
+  }
 
   // TODO: move this to NativeViewAccessibilityMac.
 #if defined(OS_MACOSX)
   if (view_->GetWidget())
     return view_->GetWidget()->GetNativeView();
 #endif
 
   if (parent_widget_)
     return parent_widget_->GetRootView()->GetNativeViewAccessible();
 
@@ skipping 12 matching lines @@
   std::vector<Widget*> child_widgets;
   PopulateChildWidgetVector(&child_widgets);
   for (Widget* child_widget : child_widgets) {
     View* child_root_view = child_widget->GetRootView();
     gfx::Point point(x, y);
     View::ConvertPointFromScreen(child_root_view, &point);
     if (child_root_view->HitTestPoint(point))
       return child_root_view->GetNativeViewAccessible();
   }
 
+  if (IsLeafElement()) {
+    if (IsIgnored())
+      return GetParent();
+    return GetNativeObject();
+  }
+
   gfx::Point point(x, y);
   View::ConvertPointFromScreen(view_, &point);
   if (!view_->HitTestPoint(point))
     return nullptr;
 
-  // Check if the point is within any of the immediate children of this
-  // view. We don't have to search further because AXPlatformNode will
-  // do a recursive hit test if we return anything other than |this| or NULL.
+  // Check if the point is within any of the immediate children of this view. We
+  // don't have to search further because AXPlatformNodeWin will do a recursive
+  // hit test if we return anything other than |GetNativeObject()| or nullptr.
   for (int i = view_->child_count() - 1; i >= 0; --i) {
     View* child_view = view_->child_at(i);
     if (!child_view->visible())
       continue;
 
     gfx::Point point_in_child_coords(point);
     view_->ConvertPointToTarget(view_, child_view, &point_in_child_coords);
     if (child_view->HitTestPoint(point_in_child_coords))
       return child_view->GetNativeViewAccessible();
   }
@@ skipping 55 matching lines @@
   }
 }
 
 void NativeViewAccessibility::SetParentWidget(Widget* parent_widget) {
   if (parent_widget_)
     parent_widget_->RemoveObserver(this);
   parent_widget_ = parent_widget;
   parent_widget_->AddObserver(this);
 }
 
+bool NativeViewAccessibility::IsLeafElement() {
+  if (GetChildCount() != 0)
+    return false;
+  return true;
+}
+
+bool NativeViewAccessibility::IsIgnored() {
+  if (view_->focus_behavior() == ClientView::FocusBehavior::NEVER)
+    return true;
+  return false;
+}
+
 void NativeViewAccessibility::PopulateChildWidgetVector(
     std::vector<Widget*>* result_child_widgets) {
   // Only attach child widgets to the root view.
   Widget* widget = view_->GetWidget();
   if (!widget || widget->GetRootView() != view_)
     return;
 
   std::set<Widget*> child_widgets;
   Widget::GetAllOwnedWidgets(widget->GetNativeView(), &child_widgets);
   for (auto iter = child_widgets.begin(); iter != child_widgets.end(); ++iter) {
@@ skipping 16 matching lines @@
               child_widget_platform_node->GetDelegate());
       if (child_widget_view_accessibility->parent_widget() != widget)
         child_widget_view_accessibility->SetParentWidget(widget);
     }
 
     result_child_widgets->push_back(child_widget);
   }
 }
 
 }  // namespace views