Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2119413002: Fix blink_perf.dom select-single-add.html. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix blink_perf.dom select-single-add.html. The test has never worked as expected. The intention of the test is to measure the performance to add OPTIONs to a SELECT element by - Adding 250 selected OPTIONs, and - Adding 250 unselected OPTIONs. But it worked expectedly only at the first run. Actually, 499 unselected OPTIONs and 1 selected OPTION were added after the first run because appendChild() updates selected state. This CL makes select-single-add.html slower intentionally. This CL doesn't affect production. BUG=625897 NOTRY=true Committed: https://crrev.com/48c94c10227b4c93bfbc4cf44081bc633c974043 Cr-Commit-Position: refs/heads/master@{#403835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/PerformanceTests/DOM/select-single-add.html View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-07-06 00:50:24 UTC) #3
keishi
LGTM
4 years, 5 months ago (2016-07-06 01:27:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119413002/1
4 years, 5 months ago (2016-07-06 01:31:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 01:36:15 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 01:36:17 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 01:38:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48c94c10227b4c93bfbc4cf44081bc633c974043
Cr-Commit-Position: refs/heads/master@{#403835}

Powered by Google App Engine
This is Rietveld 408576698