ios/chrome/BUILD.gn - Issue 2119373002: Creates coordinators for displaying alerts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/BUILD.gn

Issue 2119373002: Creates coordinators for displaying alerts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/BUILD.gn

diff --git a/ios/chrome/BUILD.gn b/ios/chrome/BUILD.gn

index 26eceb3b181dd6c43860817d17e3a5c41889a690..0f1162cb88264582f09fb757aa3218e2d8ff4990 100644

--- a/ios/chrome/BUILD.gn

+++ b/ios/chrome/BUILD.gn

@@ -64,6 +64,7 @@ test("ios_chrome_unittests") {

"browser/snapshots/snapshots_util_unittest.mm",

"browser/ssl/ios_ssl_error_handler_unittest.mm",

"browser/translate/translate_service_ios_unittest.cc",

+ "browser/ui/alert_coordinator/alert_coordinator_unittest.mm",

"browser/ui/commands/set_up_for_testing_command_unittest.mm",

"browser/ui/context_menu/context_menu_coordinator_unittest.mm",

"browser/ui/elements/selector_coordinator_unittest.mm",

@@ -117,7 +118,9 @@ test("ios_chrome_unittests") {

"//testing/gmock",

"//testing/gtest",

"//third_party/ocmock",

+ "//ui/base:base",

"//ui/gfx:test_support",

+ "//ui/strings:ui_strings_grit",

sdefresne 2016/07/22 14:16:57 Use "//ui/strings:ui_strings" instead ("//ui/strin

gambard 2016/07/25 07:23:33 Done.

]

assert_no_deps = ios_assert_no_deps

« no previous file with comments | « no previous file | ios/chrome/browser/BUILD.gn » ('j') | ios/chrome/ios_chrome.gyp » ('J')