LayoutTests/fast/events/message-port-gc-closed.html - Issue 211933008: Remove multiple GC calls and replace GCController.collect calls with GCController.collectAll

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/message-port-gc-closed.html

Issue 211933008: Remove multiple GC calls and replace GCController.collect calls with GCController.collectAll (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: revert change to worker-event-listener Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/shadow/access-document-of-detached-stylesheetlist-crash.html ('k') | LayoutTests/fast/events/message-port-gc-closed-cloned.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <body>	2 <body>

3 <script src="../../resources/js-test.js"></script>	3 <script src="../../resources/js-test.js"></script>

4 <script>	4 <script>

5 jsTestIsAsync = true;	5 jsTestIsAsync = true;

6 description("MessagePorts (and their execution contexts) should be collected by GC once close() has been called on them");	6 description("MessagePorts (and their execution contexts) should be collected by GC once close() has been called on them");

7 window.onmessage = function(evt) {	7 window.onmessage = function(evt) {

8 iframeDocGC = internals.observeGC(document.querySelector('iframe').contentDo cument);	8 iframeDocGC = internals.observeGC(document.querySelector('iframe').contentDo cument);

9 document.querySelector('iframe').remove();	9 document.querySelector('iframe').remove();

10 gc();	10 gc();

11 gc();

12 shouldBeTrue("iframeDocGC.wasCollected");	11 shouldBeTrue("iframeDocGC.wasCollected");

13 finishJSTest();	12 finishJSTest();

14 }	13 }

15 </script>	14 </script>

16 <iframe src="resources/message-port-gc-closed-iframe.html"></iframe>	15 <iframe src="resources/message-port-gc-closed-iframe.html"></iframe>

17 </body>	16 </body>

OLD	NEW