Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 211933008: Remove multiple GC calls and replace GCController.collect calls with GCController.collectAll (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, aandrey+blink_chromium.org, caseq+blink_chromium.org, alecflett, yurys+blink_chromium.org, devtools-reviews_chromium.org, nessy, loislo+blink_chromium.org, philipj_slow, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, ericu+idb_chromium.org, jsbell+idb_chromium.org, vcarbune.chromium, feature-media-reviews_chromium.org, alph+blink_chromium.org, gasubic, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, cmumford, dgrogan
Visibility:
Public.

Description

Remove multiple GC calls and replace GCController.collect calls with GCController.collectAll BUG=307614, 288072 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170018

Patch Set 1 #

Patch Set 2 : revert change to worker-event-listener #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -39 lines) Patch
M LayoutTests/fast/dom/Attr/child-nodes-cache.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/html-options-collection-lifetime.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/resources/script-element-gc.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/access-document-of-detached-stylesheetlist-crash.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/message-port-gc-closed.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/message-port-gc-closed-cloned.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/dangling-form-element-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/radio/radio-group.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/script-tests/with-scope-gc.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/workers/worker-messageport-gc.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/media/media-continues-playing-after-replace-source.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/media/track/text-track-cue-is-reachable.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/track/text-track-is-reachable.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/media/track/tracklist-is-reachable.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/multiple-plugins.html View 1 chunk +2 lines, -6 lines 0 comments Download
M LayoutTests/plugins/npruntime/leak-window-scriptable-object.html View 1 chunk +0 lines, -1 line 0 comments Download
LayoutTests/plugins/npruntime/script-tests/browser-object-identity.js View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/plugins/refcount-leaks.html View 1 chunk +1 line, -4 lines 0 comments Download
LayoutTests/resources/gc.js View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/resources/magnitude-perf.js View 1 chunk +1 line, -5 lines 0 comments Download
M LayoutTests/storage/indexeddb/cursor-cast.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/storage/websql/multiple-databases-garbage-collection.js View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/svg/dom/SVGLengthList-appendItemFromClearedList.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/SVGLengthList-basics.xhtml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
kouhei (in TOK)
6 years, 9 months ago (2014-03-26 04:32:50 UTC) #1
haraken
LGTM. Thanks for doing this. This will reduce the flakiness of GC behavior in layout ...
6 years, 9 months ago (2014-03-26 04:35:35 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 04:35:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/211933008/1
6 years, 9 months ago (2014-03-26 04:35:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 04:39:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-26 04:39:31 UTC) #6
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 04:41:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/211933008/1
6 years, 9 months ago (2014-03-26 04:41:30 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 05:03:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-26 05:03:33 UTC) #10
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 05:07:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/211933008/1
6 years, 9 months ago (2014-03-26 05:07:53 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 05:14:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-26 05:14:04 UTC) #14
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 05:19:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/211933008/1
6 years, 9 months ago (2014-03-26 05:19:10 UTC) #16
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-26 05:25:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/211933008/200001
6 years, 9 months ago (2014-03-26 05:25:39 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 05:26:29 UTC) #19
Message was sent while issue was closed. 
Change committed as 170018

Powered by Google App Engine
This is Rietveld 408576698