LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg - Issue 211933007: [SVG] call GCController.collectAll on SVG leak tests to address Oilpan flakiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg

Issue 211933007: [SVG] call GCController.collectAll on SVG leak tests to address Oilpan flakiness. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/svg/animations/smil-leak-element-instances.svg ('K') | « LayoutTests/svg/animations/smil-leak-element-instances.svg ('k') | LayoutTests/svg/animations/smil-leak-elements.svg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg

diff --git a/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg b/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg

index bc7fdae059a3a0f9e1657dcae2aaea0bb9fde722..1f2c039be865d1c7021555c78afbe3d7cde6548c 100644

--- a/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg

+++ b/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg

@@ -44,9 +44,9 @@ function cleanup() {

GCController.collect();

- // FIXME: Why 400 and not 200?

+ // This is 400 instead of 200 as it creates shadow tree elements.

var liveDelta = originalLiveElements - internals.numberOfLiveNodes() - 400;

- if (liveDelta == 0)

+ if (liveDelta <= 0)

log("PASS");

else

log("FAIL: " + liveDelta + " extra live node(s)");