Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: Source/modules/webdatabase/SQLTransactionBackend.h

Issue 211933005: Oilpan: Prepare to move SQLTransactionWrapper and CangeVersionWrapper to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webdatabase/SQLTransactionBackend.h
diff --git a/Source/modules/webdatabase/SQLTransactionBackend.h b/Source/modules/webdatabase/SQLTransactionBackend.h
index abdd1cf1e46cf2989bd9dfb247c5ee2447f20087..3ef564c5ca68ea85464114e1bd6db6ba899233d8 100644
--- a/Source/modules/webdatabase/SQLTransactionBackend.h
+++ b/Source/modules/webdatabase/SQLTransactionBackend.h
@@ -48,9 +48,10 @@ class SQLStatementBackend;
class SQLTransactionBackend;
class SQLValue;
-class SQLTransactionWrapper : public ThreadSafeRefCounted<SQLTransactionWrapper> {
+class SQLTransactionWrapper : public ThreadSafeRefCountedWillBeGarbageCollectedFinalized<SQLTransactionWrapper> {
public:
virtual ~SQLTransactionWrapper() { }
+ virtual void trace(Visitor*) = 0;
virtual bool performPreflight(SQLTransactionBackend*) = 0;
virtual bool performPostflight(SQLTransactionBackend*) = 0;
virtual SQLErrorData* sqlError() const = 0;
@@ -60,7 +61,7 @@ public:
class SQLTransactionBackend FINAL : public AbstractSQLTransactionBackend, public SQLTransactionStateMachine<SQLTransactionBackend> {
public:
static PassRefPtrWillBeRawPtr<SQLTransactionBackend> create(DatabaseBackend*,
- PassRefPtrWillBeRawPtr<AbstractSQLTransaction>, PassRefPtr<SQLTransactionWrapper>, bool readOnly);
+ PassRefPtrWillBeRawPtr<AbstractSQLTransaction>, PassRefPtrWillBeRawPtr<SQLTransactionWrapper>, bool readOnly);
virtual ~SQLTransactionBackend();
virtual void trace(Visitor*) OVERRIDE;
@@ -74,7 +75,7 @@ public:
private:
SQLTransactionBackend(DatabaseBackend*, PassRefPtrWillBeRawPtr<AbstractSQLTransaction>,
- PassRefPtr<SQLTransactionWrapper>, bool readOnly);
+ PassRefPtrWillBeRawPtr<SQLTransactionWrapper>, bool readOnly);
// APIs called from the frontend published via AbstractSQLTransactionBackend:
virtual void requestTransitToState(SQLTransactionState) OVERRIDE;
@@ -113,7 +114,7 @@ private:
RefPtrWillBeMember<SQLStatementBackend> m_currentStatementBackend;
RefPtrWillBeMember<DatabaseBackend> m_database;
- RefPtr<SQLTransactionWrapper> m_wrapper;
+ RefPtrWillBeMember<SQLTransactionWrapper> m_wrapper;
OwnPtr<SQLErrorData> m_transactionError;
bool m_hasCallback;
« no previous file with comments | « Source/modules/webdatabase/DatabaseBackend.cpp ('k') | Source/modules/webdatabase/SQLTransactionBackend.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698