Issue 211933003: [refactor] Split importKey.html into smaller files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 211933003: [refactor] Split importKey.html into smaller files. (Closed)

Created:
6 years, 9 months ago by eroman

Modified:
6 years, 9 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[refactor] Split importKey.html into smaller files, and delete algoritm-specific tests. * importKey-badParameters.html * importKey-normalize-usages.html The reason for deleting the successful key import tests, is that there are much more exhaustive key import tests as part of the clone-* layout tests (which import a large combination of keys in order to serialize them). Lastly this change fixes a typo in an error message "HmacImporParams" --> "HmacImportParams". BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170019

Patch Set 1 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -208 lines)			Patch
D	LayoutTests/crypto/importKey.html	View	1 chunk	+0 lines, -153 lines	0 comments	Download
A	LayoutTests/crypto/importKey-badParameters.html	View	1 chunk	+67 lines, -0 lines	0 comments	Download
A	LayoutTests/crypto/importKey-badParameters-expected.txt	View	1 chunk	+22 lines, -0 lines	0 comments	Download
D	LayoutTests/crypto/importKey-expected.txt	View	1 chunk	+0 lines, -51 lines	0 comments	Download
A	LayoutTests/crypto/importKey-normalize-usages.html	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A +	LayoutTests/crypto/importKey-normalize-usages-expected.txt	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/modules/crypto/NormalizeAlgorithm.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/211933003/30001

6 years, 9 months ago (2014-03-26 05:22:09 UTC) #3

Message was sent while issue was closed.

Change committed as 170019

Expand Messages | Collapse Messages