Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 2119323002: Remove obsolete tag on PageLoadMetricsClients.Reload for a while (Closed)

Created:
4 years, 5 months ago by Takashi Toyoshima
Modified:
4 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, Bryan McQuade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete tag on PageLoadMetricsClients.Reload for a while The metric was replaced with LoadType.Reload from m53, but it should be available on the UMA dashboard until the m53 goes to stable channel. BUG=625749 Committed: https://crrev.com/a6a7e27647affc935d66ca917ea94ce15340403d Cr-Commit-Position: refs/heads/master@{#404082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Takashi Toyoshima
Ilya, can you take a look this? These metrics were marked as obsolete, but it's ...
4 years, 5 months ago (2016-07-05 06:46:29 UTC) #3
Ilya Sherman
LGTM. Please remember to revert this CL after M53 goes to stable. For future reference, ...
4 years, 5 months ago (2016-07-06 23:07:57 UTC) #4
Takashi Toyoshima
Yes, I filed a bug to remember to revert this. Your coming improvements sound great! ...
4 years, 5 months ago (2016-07-07 03:45:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119323002/1
4 years, 5 months ago (2016-07-07 03:45:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 05:11:03 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 05:11:05 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 05:12:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6a7e27647affc935d66ca917ea94ce15340403d
Cr-Commit-Position: refs/heads/master@{#404082}

Powered by Google App Engine
This is Rietveld 408576698