src/isolate.cc - Issue 2119313002: Provide handle scope when printing stack trace for debugging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2119313002: Provide handle scope when printing stack trace for debugging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index afd3803e42cf10dd8b08505685906dfd237e27da..ea06d73b84f52eb313053062f271f870ce47b698 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -823,6 +823,7 @@ static void PrintFrames(Isolate* isolate,

void Isolate::PrintStack(StringStream* accumulator, PrintStackMode mode) {

// The MentionedObjectCache is not GC-proof at the moment.

DisallowHeapAllocation no_gc;

+ HandleScope scope(this);

DCHECK(accumulator->IsMentionedObjectCacheClear(this));

// Avoid printing anything if there are no frames.

« no previous file with comments | « no previous file | no next file » | no next file with comments »