Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2119313002: Provide handle scope when printing stack trace for debugging. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Provide handle scope when printing stack trace for debugging. It would be nice for 'jst' to work even when no handle scope has been created yet. R=cbruni@chromium.org Committed: https://crrev.com/70e72549f0a05dbaec9958d15d430fbfd9c40f2d Cr-Commit-Position: refs/heads/master@{#37541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 5 months ago (2016-07-05 06:41:57 UTC) #1
Camillo Bruni
lgtm
4 years, 5 months ago (2016-07-05 13:54:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119313002/1
4 years, 5 months ago (2016-07-06 05:31:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 05:53:53 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 05:55:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70e72549f0a05dbaec9958d15d430fbfd9c40f2d
Cr-Commit-Position: refs/heads/master@{#37541}

Powered by Google App Engine
This is Rietveld 408576698