Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2119283004: Remove unused helpers to selectively traverse through only local frames. (Closed)

Created:
4 years, 5 months ago by dcheng
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch, dglazkov+blink, blink-reviews-api_chromium.org, paulmeyer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused helpers to selectively traverse through only local frames. This was introduced in https://crrev.com/374212 so find-in-page would crash less prior to full OOPIF support. It is no longer used and should be removed. BUG=none Committed: https://crrev.com/7095ede0f6d105e372e0035858a77bdd22414db2 Cr-Commit-Position: refs/heads/master@{#403900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dcheng
4 years, 5 months ago (2016-07-06 12:54:27 UTC) #4
alex clarke (OOO till 29th)
lgtm
4 years, 5 months ago (2016-07-06 13:07:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119283004/1
4 years, 5 months ago (2016-07-06 13:45:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 13:49:32 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 13:49:37 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 13:51:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7095ede0f6d105e372e0035858a77bdd22414db2
Cr-Commit-Position: refs/heads/master@{#403900}

Powered by Google App Engine
This is Rietveld 408576698