Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4150)

Unified Diff: chrome/browser/android/chrome_service_tab_launcher.cc

Issue 2119273002: Merge ChromeServiceTabLauncher and ServiceTabLauncher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into chrome_service_tab_launcher Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/chrome_service_tab_launcher.cc
diff --git a/components/service_tab_launcher/browser/android/service_tab_launcher.cc b/chrome/browser/android/chrome_service_tab_launcher.cc
similarity index 75%
rename from components/service_tab_launcher/browser/android/service_tab_launcher.cc
rename to chrome/browser/android/chrome_service_tab_launcher.cc
index f4691815f690833fae1fce95bad9fc5444078064..cbc9ad9b6e6af4c6495e0d54cd79fa992521696e 100644
--- a/components/service_tab_launcher/browser/android/service_tab_launcher.cc
+++ b/chrome/browser/android/chrome_service_tab_launcher.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/service_tab_launcher/browser/android/service_tab_launcher.h"
+#include "chrome/browser/android/chrome_service_tab_launcher.h"
#include "base/android/context_utils.h"
#include "base/android/jni_string.h"
@@ -10,7 +10,7 @@
#include "content/public/browser/browser_context.h"
#include "content/public/browser/page_navigator.h"
#include "content/public/browser/web_contents.h"
-#include "jni/ServiceTabLauncher_jni.h"
+#include "jni/ChromeServiceTabLauncher_jni.h"
using base::android::AttachCurrentThread;
using base::android::ConvertUTF8ToJavaString;
@@ -22,27 +22,24 @@ void OnWebContentsForRequestAvailable(
const JavaParamRef<jclass>& clazz,
jint request_id,
const JavaParamRef<jobject>& android_web_contents) {
- service_tab_launcher::ServiceTabLauncher::GetInstance()->OnTabLaunched(
+ ChromeServiceTabLauncher::GetInstance()->OnTabLaunched(
request_id,
content::WebContents::FromJavaWebContents(android_web_contents));
}
-namespace service_tab_launcher {
-
// static
-ServiceTabLauncher* ServiceTabLauncher::GetInstance() {
- return base::Singleton<ServiceTabLauncher>::get();
+ChromeServiceTabLauncher* ChromeServiceTabLauncher::GetInstance() {
+ return base::Singleton<ChromeServiceTabLauncher>::get();
}
-ServiceTabLauncher::ServiceTabLauncher() {
- java_object_.Reset(
- Java_ServiceTabLauncher_getInstance(AttachCurrentThread(),
- GetApplicationContext()));
+ChromeServiceTabLauncher::ChromeServiceTabLauncher() {
+ java_object_.Reset(Java_ChromeServiceTabLauncher_getInstance(
+ AttachCurrentThread(), GetApplicationContext()));
}
-ServiceTabLauncher::~ServiceTabLauncher() {}
+ChromeServiceTabLauncher::~ChromeServiceTabLauncher() {}
-void ServiceTabLauncher::LaunchTab(
+void ChromeServiceTabLauncher::LaunchTab(
content::BrowserContext* browser_context,
const content::OpenURLParams& params,
const TabLaunchedCallback& callback) {
@@ -74,7 +71,7 @@ void ServiceTabLauncher::LaunchTab(
new TabLaunchedCallback(callback));
DCHECK_GE(request_id, 1);
- Java_ServiceTabLauncher_launchTab(env,
+ Java_ChromeServiceTabLauncher_launchTab(env,
java_object_.obj(),
GetApplicationContext(),
request_id,
@@ -87,8 +84,9 @@ void ServiceTabLauncher::LaunchTab(
post_data.obj());
}
-void ServiceTabLauncher::OnTabLaunched(int request_id,
- content::WebContents* web_contents) {
+void ChromeServiceTabLauncher::OnTabLaunched(
+ int request_id,
+ content::WebContents* web_contents) {
TabLaunchedCallback* callback = tab_launched_callbacks_.Lookup(request_id);
DCHECK(callback);
@@ -98,8 +96,6 @@ void ServiceTabLauncher::OnTabLaunched(int request_id,
tab_launched_callbacks_.Remove(request_id);
}
-bool ServiceTabLauncher::RegisterServiceTabLauncher(JNIEnv* env) {
+bool ChromeServiceTabLauncher::Register(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-
-} // namespace service_tab_launcher

Powered by Google App Engine
This is Rietveld 408576698