Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2119273002: Merge ChromeServiceTabLauncher and ServiceTabLauncher (Closed)

Created:
4 years, 5 months ago by pkotwicz
Modified:
4 years, 5 months ago
Reviewers:
Peter Beverloo, Yaron
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge ChromeServiceTabLauncher and ServiceTabLauncher BUG=614594 R=yfriedman TBR=peter Committed: https://crrev.com/aa289f074c16619af0b14083a3e48a0224ea7e57 Cr-Commit-Position: refs/heads/master@{#403829}

Patch Set 1 : Merge branch 'master' into chrome_service_tab_launcher #

Total comments: 5

Patch Set 2 : Merge branch 'master' into chrome_service_tab_launcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -599 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/AndroidManifest.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java View 1 1 chunk +0 lines, -109 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java View 1 4 chunks +42 lines, -18 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParams.java View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/android/service_tab_launcher.h View 1 4 chunks +4 lines, -10 lines 0 comments Download
A + chrome/browser/android/service_tab_launcher.cc View 1 4 chunks +6 lines, -21 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 3 chunks +3 lines, -1 line 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D components/service_tab_launcher.gypi View 1 chunk +0 lines, -52 lines 0 comments Download
D components/service_tab_launcher/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
D components/service_tab_launcher/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/service_tab_launcher/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/service_tab_launcher/android/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/service_tab_launcher/android/java/src/org/chromium/components/service_tab_launcher/ServiceTabLauncher.java View 1 chunk +0 lines, -112 lines 0 comments Download
D components/service_tab_launcher/browser/android/service_tab_launcher.h View 1 chunk +0 lines, -62 lines 0 comments Download
D components/service_tab_launcher/browser/android/service_tab_launcher.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D components/service_tab_launcher/component_jni_registrar.h View 1 chunk +0 lines, -17 lines 0 comments Download
D components/service_tab_launcher/component_jni_registrar.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
pkotwicz
Peter Beverloo can you please take a look?
4 years, 5 months ago (2016-07-05 01:03:55 UTC) #6
Peter Beverloo
Thanks! lgtm w/ some suggestions https://codereview.chromium.org/2119273002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java (right): https://codereview.chromium.org/2119273002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java#newcode39 chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java:39: "org.chromium.components.service_tab_launcher.ServiceTabLauncher.LAUNCH_REQUEST_ID"; nit: org.chromium.chrome.browser.ServiceTabLauncher.LAUNCH_REQUEST_ID? https://codereview.chromium.org/2119273002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java#newcode57 ...
4 years, 5 months ago (2016-07-05 11:23:04 UTC) #7
pkotwicz
Yaron for OWNERS https://codereview.chromium.org/2119273002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java (right): https://codereview.chromium.org/2119273002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java#newcode57 chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java:57: public void launchTab(final Context context, final ...
4 years, 5 months ago (2016-07-05 17:09:59 UTC) #12
pkotwicz
Yaron for OWNERS https://codereview.chromium.org/2119273002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java (right): https://codereview.chromium.org/2119273002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java#newcode57 chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java:57: public void launchTab(final Context context, final ...
4 years, 5 months ago (2016-07-05 17:10:00 UTC) #13
Yaron
lgtm
4 years, 5 months ago (2016-07-05 18:14:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119273002/120001
4 years, 5 months ago (2016-07-05 18:48:26 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/212535)
4 years, 5 months ago (2016-07-05 18:56:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119273002/120001
4 years, 5 months ago (2016-07-05 21:59:30 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 5 months ago (2016-07-05 22:26:37 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 22:27:57 UTC) #26
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/aa289f074c16619af0b14083a3e48a0224ea7e57
Cr-Commit-Position: refs/heads/master@{#403829}

Powered by Google App Engine
This is Rietveld 408576698