Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2119253002:
Add time in suspended state histograms for Shill (Closed)
DescriptionAdd time in suspended state histograms for Shill
Add Network.Shill.WiFi.SuspendDuration* histograms
to track time spent in suspended state for different
cases of connection status on resume.
BUG=614790
Committed: https://crrev.com/de7c54f9ca5a04d4734fdcd5b58e586ed36b6a56
Cr-Commit-Position: refs/heads/master@{#404038}
Patch Set 1 #Patch Set 2 : Correct formatting in histograms.xml #Messages
Total messages: 32 (16 generated)
Description was changed from ========== Add time in suspended state histograms for Shill Add Network.Shill.WiFi.SuspendDuration* histograms to track time spent in suspended state for different cases of connection status on resume. BUG=614790 ========== to ========== Add time in suspended state histograms for Shill Add Network.Shill.WiFi.SuspendDuration* histograms to track time spent in suspended state for different cases of connection status on resume. BUG=614790 ==========
kirtika@chromium.org changed reviewers: + asvitkine@chromium.org, semenzato@chromium.org, snanda@chromium.org
Changed as per feedback here: https://chromium-review.googlesource.com/#/c/347486/ and moved from Gerrit to Reitveld. Apologies for the inconvenience.
lgtm
The CQ bit was checked by kirtika@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
The CQ bit was checked by kirtika@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by kirtika@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by kirtika@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/2119253002/#ps20001 (title: "Correct formatting in histograms.xml")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kirtika@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kirtika@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add time in suspended state histograms for Shill Add Network.Shill.WiFi.SuspendDuration* histograms to track time spent in suspended state for different cases of connection status on resume. BUG=614790 ========== to ========== Add time in suspended state histograms for Shill Add Network.Shill.WiFi.SuspendDuration* histograms to track time spent in suspended state for different cases of connection status on resume. BUG=614790 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Add time in suspended state histograms for Shill Add Network.Shill.WiFi.SuspendDuration* histograms to track time spent in suspended state for different cases of connection status on resume. BUG=614790 ========== to ========== Add time in suspended state histograms for Shill Add Network.Shill.WiFi.SuspendDuration* histograms to track time spent in suspended state for different cases of connection status on resume. BUG=614790 Committed: https://crrev.com/de7c54f9ca5a04d4734fdcd5b58e586ed36b6a56 Cr-Commit-Position: refs/heads/master@{#404038} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/de7c54f9ca5a04d4734fdcd5b58e586ed36b6a56 Cr-Commit-Position: refs/heads/master@{#404038} |
