Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2119243002: Reapply zone tasks. (Closed)

Created:
4 years, 5 months ago by floitsch
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix types in xhr_task2_test #

Patch Set 3 : Update status file for windows (xhr). #

Patch Set 4 : Update status file for IE. #

Patch Set 5 : Upload after revert and rebase #

Patch Set 6 : Fix test and update status files for IE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3905 lines, -222 lines) Patch
M sdk/lib/async/timer.dart View 3 chunks +139 lines, -8 lines 0 comments Download
M sdk/lib/async/zone.dart View 1 32 chunks +353 lines, -64 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 21 chunks +431 lines, -50 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 20 chunks +400 lines, -49 lines 0 comments Download
A tests/html/event_subscription_specification_test.dart View 1 chunk +121 lines, -0 lines 0 comments Download
A tests/html/event_zone_task_test.dart View 1 chunk +239 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 2 3 4 5 4 chunks +5 lines, -1 line 0 comments Download
A tests/html/request_animation_task_test.dart View 1 2 3 4 5 1 chunk +170 lines, -0 lines 0 comments Download
A tests/html/xhr_task2_test.dart View 1 1 chunk +280 lines, -0 lines 0 comments Download
A tests/html/xhr_task_test.dart View 1 chunk +508 lines, -0 lines 0 comments Download
A tests/lib/async/zone_task_test.dart View 1 chunk +310 lines, -0 lines 0 comments Download
A tests/lib/async/zone_timer_task_test.dart View 1 chunk +515 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/docs/docs.json View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 9 chunks +99 lines, -16 lines 0 comments Download
M tools/dom/src/shared_html.dart View 1 chunk +14 lines, -19 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 4 chunks +125 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 6 chunks +190 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
floitsch
Seems like I only needed to fix a few types in a test, and update ...
4 years, 5 months ago (2016-07-04 17:55:40 UTC) #2
floitsch
Committed patchset #4 (id:60001) manually as f746f8f77e93fd93cb4ff3b4ed644c96a432947a (presubmit successful).
4 years, 5 months ago (2016-07-04 17:56:05 UTC) #4
floitsch
Note: patch set 1 is the original CLs (revert of revert).
4 years, 5 months ago (2016-07-04 17:56:24 UTC) #5
Lasse Reichstein Nielsen
lgtm
4 years, 5 months ago (2016-07-04 18:12:27 UTC) #6
floitsch
Updated the tests and status files. Landing again. TBR.
4 years, 5 months ago (2016-07-05 15:33:02 UTC) #8
floitsch
4 years, 5 months ago (2016-07-05 15:33:16 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
6a7c037aa62b68215d0e8bdaf16e5477383f4687 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698