Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2119223002: Remove dead ntp_tiles thumbnail-related code. (Closed)

Created:
4 years, 5 months ago by sfiera
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead ntp_tiles thumbnail-related code. Included a reference to SkBitmap, which won't compile on iOS. BUG=617966 Committed: https://crrev.com/33a73461966a7c727e9400bb61b39c2bea188276 Cr-Commit-Position: refs/heads/master@{#403688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M components/ntp_tiles/most_visited_sites.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sfiera
4 years, 5 months ago (2016-07-04 15:02:57 UTC) #3
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-04 15:05:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119223002/1
4 years, 5 months ago (2016-07-04 15:06:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 15:47:39 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 15:49:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33a73461966a7c727e9400bb61b39c2bea188276
Cr-Commit-Position: refs/heads/master@{#403688}

Powered by Google App Engine
This is Rietveld 408576698