Issue 21192002: Remove more methods from PluginDelegate. Some I moved the implementationto the callers. For others,…

Issue 21192002: Remove more methods from PluginDelegate. Some I moved the implementationto the callers. For others,… (Closed)

Created:
7 years, 4 months ago by jam

Modified:
7 years, 4 months ago

Reviewers:
scottmg

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove more methods from PluginDelegate. Some I moved the implementation to the callers. For others, I have them call to PepperPluginDelegateImpl directly. This is in anticipation of removing PluginDelegate completely, and probably having PepperPluginDelegateImpl remain as a Pepper helper per RenderView, which it also serves as today. BUG=263054 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214295

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+170 lines, -460 lines)			Patch
M	content/common/pepper_messages.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/renderer/render_view_observer.h	View	1 chunk	+4 lines, -4 lines	1 comment	Download
M	content/renderer/pepper/mock_plugin_delegate.h	View	2 chunks	+1 line, -39 lines	0 comments	Download
M	content/renderer/pepper/mock_plugin_delegate.cc	View	2 chunks	+0 lines, -81 lines	0 comments	Download
M	content/renderer/pepper/pepper_browser_connection.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.h	View	6 chunks	+14 lines, -53 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.cc	View	7 chunks	+6 lines, -172 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_instance_impl.h	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_instance_impl.cc	View	11 chunks	+73 lines, -10 lines	0 comments	Download
M	content/renderer/pepper/plugin_delegate.h	View	3 chunks	+0 lines, -67 lines	0 comments	Download
M	content/renderer/pepper/ppb_tcp_server_socket_private_impl.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/ppb_tcp_server_socket_private_impl.cc	View	2 chunks	+20 lines, -7 lines	0 comments	Download
M	content/renderer/pepper/ppb_tcp_socket_private_impl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/ppb_tcp_socket_private_impl.cc	View	5 chunks	+33 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

https://codereview.chromium.org/21192002/diff/1/content/public/renderer/render_view_observer.h File content/public/renderer/render_view_observer.h (right): https://codereview.chromium.org/21192002/diff/1/content/public/renderer/render_view_observer.h#newcode105 content/public/renderer/render_view_observer.h:105: // IPC::Sender implementation. i originally wrote this and thought ...

7 years, 4 months ago (2013-07-30 01:49:22 UTC) #1

lgtm

Expand Messages | Collapse Messages