Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2119193002: Compute correct names for closures in operator methods. (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute correct names for closures in operator methods. Operators were not correctly recognized because of the use of identical instead of == and thus closures contained untransformed operators in their names. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/3fcadea4055e86aaf48b5d71d3518c556464c3cb

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -48 lines) Patch
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +4 lines, -9 lines 1 comment Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +20 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 2 chunks +3 lines, -9 lines 1 comment Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +9 lines, -9 lines 1 comment Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +1 line, -1 line 1 comment Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/2119193002/diff/1/pkg/compiler/lib/src/constants/expressions.dart File pkg/compiler/lib/src/constants/expressions.dart (right): https://codereview.chromium.org/2119193002/diff/1/pkg/compiler/lib/src/constants/expressions.dart#newcode487 pkg/compiler/lib/src/constants/expressions.dart:487: for (int index = 0; index < keys.length; index++) ...
4 years, 5 months ago (2016-07-04 13:40:36 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-07-06 16:11:27 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-08 08:10:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fcadea4055e86aaf48b5d71d3518c556464c3cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698