content/browser/service_worker/service_worker_registration.h - Issue 2119143002: service worker: Wait for inflight requests before activating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.h

Issue 2119143002: service worker: Wait for inflight requests before activating (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: private Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_registration.cc » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/activation.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.h

diff --git a/content/browser/service_worker/service_worker_registration.h b/content/browser/service_worker/service_worker_registration.h

index f5dc4344b22e8e06a2d7d7fd560cbe7470bff2d5..43cfe94bbbccfa4a48f650d10d16493dcbc19c27 100644

--- a/content/browser/service_worker/service_worker_registration.h

+++ b/content/browser/service_worker/service_worker_registration.h

@@ -161,6 +161,9 @@ class CONTENT_EXPORT ServiceWorkerRegistration

// ServiceWorkerVersion::Listener override.

void OnNoControllees(ServiceWorkerVersion* version) override;

+ void OnNoInflightRequests(ServiceWorkerVersion* version) override;

+ bool IsReadyToActivate() const;

// Promotes the waiting version to active version. If |delay| is true, waits

// a short time before attempting to start and dispatch the activate event