Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2119123002: Don't batch large instanced rects with other shapes (Closed)

Created:
4 years, 5 months ago by csmartdalton
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't batch large instanced rects with other shapes Sets a threshold for total area after which rectangles will no longer batch with other types of shapes. The round rect shader is more expensive, so once we become sufficiently GPU-bound it no longer makes sense to do these combinations. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119123002

Patch Set 1 #

Patch Set 2 : Don't batch large instanced rects with other shapes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -25 lines) Patch
M bench/ShapesBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/instanced/InstancedRendering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/instanced/InstancedRendering.cpp View 2 chunks +18 lines, -2 lines 0 comments Download
M src/gpu/instanced/InstancedRenderingTypes.h View 1 2 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
csmartdalton
4 years, 5 months ago (2016-07-04 05:24:38 UTC) #3
csmartdalton
4 years, 5 months ago (2016-07-05 23:09:01 UTC) #5
Message was sent while issue was closed.
Rolled into https://codereview.chromium.org/2066993003/

Powered by Google App Engine
This is Rietveld 408576698