Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2119113002: MD History: Fix item sizing in small windows (Closed)

Created:
4 years, 5 months ago by tsergeant
Modified:
4 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix item sizing in small windows This CL introduces a style mixin which can be applied consistently across pages to show content with the correct padding and width. Using this mixin fixes an issue where some content was hidden off the left of the page in small window sizes. BUG=625057 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b9999d69a942ce4d7caad87bd5cadddcea313779 Cr-Commit-Position: refs/heads/master@{#403866}

Patch Set 1 #

Patch Set 2 : Apply to grouped history #

Patch Set 3 : Tweak comment #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -44 lines) Patch
M chrome/browser/resources/md_history/grouped_list.html View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 2 3 2 chunks +37 lines, -35 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tsergeant
4 years, 5 months ago (2016-07-04 05:34:26 UTC) #4
calamity
Cool solution. lgtm.
4 years, 5 months ago (2016-07-06 07:32:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119113002/60001
4 years, 5 months ago (2016-07-06 07:50:00 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-06 08:23:46 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 08:23:55 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 08:25:12 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b9999d69a942ce4d7caad87bd5cadddcea313779
Cr-Commit-Position: refs/heads/master@{#403866}

Powered by Google App Engine
This is Rietveld 408576698