[Material][Mac] Implement Omnibox Verbose State Chips

ui/gfx/animation/tween.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_ANIMATION_TWEEN_H_
 #define UI_GFX_ANIMATION_TWEEN_H_
 
 #include "base/macros.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/gfx_export.h"
 #include "ui/gfx/transform.h"
 
 namespace base {
 class TimeTicks;
 }
 
 namespace gfx {
 
 class GFX_EXPORT Tween {
  public:
   enum Type {
-    LINEAR,             // Linear.
-    EASE_OUT,           // Fast in, slow out (default).
-    EASE_IN,            // Slow in, fast out.
-    EASE_IN_2,          // Variant of EASE_IN that starts out slower than
-                        // EASE_IN.
-    EASE_IN_OUT,        // Slow in and out, fast in the middle.
-    FAST_IN_OUT,        // Fast in and out, slow in the middle.
-    EASE_OUT_SNAP,      // Fast in, slow out, snap to final value.
-    SMOOTH_IN_OUT,      // Smooth, consistent speeds in and out (sine wave).
-    FAST_OUT_SLOW_IN,   // Variant of EASE_IN_OUT which should be used in most
-                        // cases.
-    LINEAR_OUT_SLOW_IN, // Variant of EASE_OUT which should be used for
-                        // fading in from 0% or motion when entering a scene.
-    FAST_OUT_LINEAR_IN, // Variant of EASE_IN which should should be used for
-                        // fading out to 0% or motion when exiting a scene.
-    ZERO,               // Returns a value of 0 always.
+    LINEAR,            // Linear.
+    EASE_OUT,          // Fast in, slow out (default).
+    EASE_IN,           // Slow in, fast out.
+    EASE_IN_2,         // Variant of EASE_IN that starts out slower than
+                       // EASE_IN.
+    EASE_IN_OUT,       // Slow in and out, fast in the middle.
+    FAST_IN_OUT,       // Fast in and out, slow in the middle.
+    EASE_OUT_SNAP,     // Fast in, slow out, snap to final value.
+    SMOOTH_IN_OUT,     // Smooth, consistent speeds in and out (sine wave).
+    FAST_OUT_SLOW_IN,  // Variant of EASE_IN_OUT which should be used in most
+                       // cases.
+    FAST_OUT_SLOW_IN_EXPO,  // Exponential variant of FAST_OUT_SLOW_IN.

[Peter Kasting, 2016/08/18 21:15:00]

I'm not keen on the functional creep of how we keep getting more animations over
time.  We should have a small number of animation curves and use them everywhere
-- we already have about 3x as many as we should have.

Can we push the designers to either:
* Use one of the existing curves
* Change one of the existing curves to do what they want, then use it

In either case, we shouldn't wind up with a unique thing for this UI surface.

[spqchan, 2016/08/18 21:56:32]

I can email emilyschechter to see if UI is willing to use an existing curve. I'm
not sure how we can change
one of the existing curves. I did noticed that FAST_IN_OUT is unused though and
removed it. Is that what you mean?

One more alternative, I can just store the curve in
security_state_bubble_decoration and use it from there but it makes more sense
to have something that can be shared between platforms/

[Peter Kasting, 2016/08/18 22:05:09]

For example, we decide to change the constants on the existing FAST_OUT_SLOW_IN
curve to match the new ones you want, so everyone using that curve get the new
behavior.
That's certainly a good thing to do, but what I'm getting at really is that the
number of values in the enum is merely symptomatic of the root problem, which is
that we have lots of different animation behaviors.  We should be trying to get
to a world with a small number, each of which is used broadly.  Removing an
unused enum value while adding a new one with one use doesn't make that
underlying problem better.

[spqchan, 2016/08/18 22:18:33]

I see what you mean. Sure thing, currently we're using FAST_OUT_SLOW_IN to
animate in, and the variant to animate out. I'll ask to see if we can just stick
with FAST_OUT_SLOW_IN for animating out

+    LINEAR_OUT_SLOW_IN,     // Variant of EASE_OUT which should be used for
+    // fading in from 0% or motion when entering a scene.
+    FAST_OUT_LINEAR_IN,  // Variant of EASE_IN which should should be used for
+                         // fading out to 0% or motion when exiting a scene.
+    ZERO,                // Returns a value of 0 always.
   };
 
   // Returns the value based on the tween type. |state| is from 0-1.
   static double CalculateValue(Type type, double state);
 
   // Conveniences for getting a value between a start and end point.
   static SkColor ColorValueBetween(double value, SkColor start, SkColor target);
   static double DoubleValueBetween(double value, double start, double target);
   static float FloatValueBetween(double value, float start, float target);
   static float ClampedFloatValueBetween(const base::TimeTicks& time,
@@ skipping 23 matching lines @@
  private:
   Tween();
   ~Tween();
 
   DISALLOW_COPY_AND_ASSIGN(Tween);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_ANIMATION_TWEEN_H_