Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2119023002: [Android] Guard android_assets usage with enable_java_templates. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Android] Guard android_assets usage with enable_java_templates. BUG=pdfium:38 R=jshin@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/a5f86adbb0a58d04c035a5d1228747b1823cd485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jbudorick
4 years, 5 months ago (2016-07-02 00:01:14 UTC) #2
jbudorick
ping
4 years, 5 months ago (2016-07-08 13:32:25 UTC) #3
jungshik at Google
Sorry for the delay. I really don't understand what 'enable_java_templates' does, but if it's required ...
4 years, 5 months ago (2016-07-08 20:37:18 UTC) #4
jungshik at Google
On 2016/07/08 20:37:18, jungshik at google wrote: > Sorry for the delay. I really don't ...
4 years, 5 months ago (2016-07-08 20:37:27 UTC) #5
jbudorick
On 2016/07/08 20:37:27, jungshik at google wrote: > On 2016/07/08 20:37:18, jungshik at google wrote: ...
4 years, 5 months ago (2016-07-08 20:43:46 UTC) #6
jbudorick
4 years, 5 months ago (2016-07-08 20:46:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a5f86adbb0a58d04c035a5d1228747b1823cd485 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698