Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Side by Side Diff: core/fpdfapi/fpdf_page/include/cpdf_formobject.h

Issue 2119013002: Change class member variables in raw pointer type into unique_ptr (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/fpdf_page/fpdf_page_parser.cpp ('k') | core/fpdfapi/fpdf_render/fpdf_render.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_ 7 #ifndef CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_
8 #define CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_ 8 #define CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_
9 9
10 #include <memory>
11
10 #include "core/fpdfapi/fpdf_page/include/cpdf_pageobject.h" 12 #include "core/fpdfapi/fpdf_page/include/cpdf_pageobject.h"
11 #include "core/fxcrt/include/fx_coordinates.h" 13 #include "core/fxcrt/include/fx_coordinates.h"
12 14
13 class CPDF_Form; 15 class CPDF_Form;
14 16
15 class CPDF_FormObject : public CPDF_PageObject { 17 class CPDF_FormObject : public CPDF_PageObject {
16 public: 18 public:
17 CPDF_FormObject(); 19 CPDF_FormObject();
18 ~CPDF_FormObject() override; 20 ~CPDF_FormObject() override;
19 21
20 // CPDF_PageObject: 22 // CPDF_PageObject:
21 CPDF_FormObject* Clone() const override; 23 CPDF_FormObject* Clone() const override;
22 Type GetType() const override; 24 Type GetType() const override;
23 void Transform(const CFX_Matrix& matrix) override; 25 void Transform(const CFX_Matrix& matrix) override;
24 bool IsForm() const override; 26 bool IsForm() const override;
25 CPDF_FormObject* AsForm() override; 27 CPDF_FormObject* AsForm() override;
26 const CPDF_FormObject* AsForm() const override; 28 const CPDF_FormObject* AsForm() const override;
27 29
28 void CalcBoundingBox(); 30 void CalcBoundingBox();
29 31
30 CPDF_Form* m_pForm; 32 std::unique_ptr<CPDF_Form> m_pForm;
31 CFX_Matrix m_FormMatrix; 33 CFX_Matrix m_FormMatrix;
32 }; 34 };
33 35
34 #endif // CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_ 36 #endif // CORE_FPDFAPI_FPDF_PAGE_INCLUDE_CPDF_FORMOBJECT_H_
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_page/fpdf_page_parser.cpp ('k') | core/fpdfapi/fpdf_render/fpdf_render.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698