Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Side by Side Diff: core/fpdfapi/fpdf_page/cpdf_formobject.cpp

Issue 2119013002: Change class member variables in raw pointer type into unique_ptr (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/fpdf_font/ttgsubtable.cpp ('k') | core/fpdfapi/fpdf_page/fpdf_page_parser.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/fpdf_page/include/cpdf_formobject.h" 7 #include "core/fpdfapi/fpdf_page/include/cpdf_formobject.h"
8 8
9 #include "core/fpdfapi/fpdf_page/include/cpdf_form.h" 9 #include "core/fpdfapi/fpdf_page/include/cpdf_form.h"
10 10
11 CPDF_FormObject::CPDF_FormObject() : m_pForm(nullptr) {} 11 CPDF_FormObject::CPDF_FormObject() {}
12 12
13 CPDF_FormObject::~CPDF_FormObject() { 13 CPDF_FormObject::~CPDF_FormObject() {}
14 delete m_pForm;
15 }
16 14
17 void CPDF_FormObject::Transform(const CFX_Matrix& matrix) { 15 void CPDF_FormObject::Transform(const CFX_Matrix& matrix) {
18 m_FormMatrix.Concat(matrix); 16 m_FormMatrix.Concat(matrix);
19 CalcBoundingBox(); 17 CalcBoundingBox();
20 } 18 }
21 19
22 bool CPDF_FormObject::IsForm() const { 20 bool CPDF_FormObject::IsForm() const {
23 return true; 21 return true;
24 } 22 }
25 23
26 CPDF_FormObject* CPDF_FormObject::AsForm() { 24 CPDF_FormObject* CPDF_FormObject::AsForm() {
27 return this; 25 return this;
28 } 26 }
29 27
30 const CPDF_FormObject* CPDF_FormObject::AsForm() const { 28 const CPDF_FormObject* CPDF_FormObject::AsForm() const {
31 return this; 29 return this;
32 } 30 }
33 31
34 CPDF_FormObject* CPDF_FormObject::Clone() const { 32 CPDF_FormObject* CPDF_FormObject::Clone() const {
35 CPDF_FormObject* obj = new CPDF_FormObject; 33 CPDF_FormObject* obj = new CPDF_FormObject;
36 obj->CopyData(this); 34 obj->CopyData(this);
37 35
38 obj->m_pForm = m_pForm->Clone(); 36 obj->m_pForm.reset(m_pForm->Clone());
39 obj->m_FormMatrix = m_FormMatrix; 37 obj->m_FormMatrix = m_FormMatrix;
40 return obj; 38 return obj;
41 } 39 }
42 40
43 CPDF_PageObject::Type CPDF_FormObject::GetType() const { 41 CPDF_PageObject::Type CPDF_FormObject::GetType() const {
44 return FORM; 42 return FORM;
45 } 43 }
46 44
47 void CPDF_FormObject::CalcBoundingBox() { 45 void CPDF_FormObject::CalcBoundingBox() {
48 CFX_FloatRect form_rect = m_pForm->CalcBoundingBox(); 46 CFX_FloatRect form_rect = m_pForm->CalcBoundingBox();
49 form_rect.Transform(&m_FormMatrix); 47 form_rect.Transform(&m_FormMatrix);
50 m_Left = form_rect.left; 48 m_Left = form_rect.left;
51 m_Bottom = form_rect.bottom; 49 m_Bottom = form_rect.bottom;
52 m_Right = form_rect.right; 50 m_Right = form_rect.right;
53 m_Top = form_rect.top; 51 m_Top = form_rect.top;
54 } 52 }
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_font/ttgsubtable.cpp ('k') | core/fpdfapi/fpdf_page/fpdf_page_parser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698