Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2118973002: Version 5.2.361.34 (cherry-pick) (Closed)

Created:
4 years, 5 months ago by Dan Ehrenberg
Modified:
4 years, 5 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.2
Target Ref:
refs/pending/branch-heads/5.2
Project:
v8
Visibility:
Public.

Description

Version 5.2.361.34 (cherry-pick) Merged 34880eb3dcf7492d44c0a3b45b6c888189f2c3c3 Revert of Put RegExp js code in strict mode (patchset #2 id:20001 of https://codereview.chromium.org/1776883005/ ) BUG=chromium:624318 LOG=N R=adamk@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/b63de17426eb45352d03f263f5bb2271de003a44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/js/regexp.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/regexp-lastIndex.js View 1 chunk +0 lines, -18 lines 0 comments Download
M test/test262/test262.status View 1 chunk +16 lines, -0 lines 0 comments Download
M test/webkit/fast/regex/lastIndex-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Dan Ehrenberg
4 years, 5 months ago (2016-07-01 21:29:15 UTC) #1
adamk
lgtm
4 years, 5 months ago (2016-07-01 21:30:15 UTC) #2
Dan Ehrenberg
4 years, 5 months ago (2016-07-01 21:37:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b63de17426eb45352d03f263f5bb2271de003a44.

Powered by Google App Engine
This is Rietveld 408576698