Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: tools/testing/dart/compiler_configuration.dart

Issue 2118923002: Add --hot-reload-test-mode flag to embedder and wire it up to test.py (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rmacnak review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler_configuration; 5 library compiler_configuration;
6 6
7 import 'dart:io' show Platform; 7 import 'dart:io' show Platform;
8 8
9 import 'runtime_configuration.dart' show RuntimeConfiguration; 9 import 'runtime_configuration.dart' show RuntimeConfiguration;
10 10
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 List<String> vmOptions, 172 List<String> vmOptions,
173 List<String> sharedOptions, 173 List<String> sharedOptions,
174 List<String> originalArguments, 174 List<String> originalArguments,
175 CommandArtifact artifact) { 175 CommandArtifact artifact) {
176 List<String> args = []; 176 List<String> args = [];
177 if (isChecked) { 177 if (isChecked) {
178 args.add('--enable_asserts'); 178 args.add('--enable_asserts');
179 args.add('--enable_type_checks'); 179 args.add('--enable_type_checks');
180 } 180 }
181 if (hotReload) { 181 if (hotReload) {
182 args.add('--identity-reload'); 182 args.add('--hot-reload-test-mode');
183 args.add('--reload-every=100000'); 183 // Remove the following once known bugs with background compilation
184 // and OSR are fixed.
184 args.add('--no-background-compilation'); 185 args.add('--no-background-compilation');
185 args.add('--no-osr'); 186 args.add('--no-osr');
186 } 187 }
187 return args 188 return args
188 ..addAll(vmOptions) 189 ..addAll(vmOptions)
189 ..addAll(sharedOptions) 190 ..addAll(sharedOptions)
190 ..addAll(originalArguments); 191 ..addAll(originalArguments);
191 } 192 }
192 } 193 }
193 194
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
651 RuntimeConfiguration runtimeConfiguration, 652 RuntimeConfiguration runtimeConfiguration,
652 String buildDir, 653 String buildDir,
653 TestInformation info, 654 TestInformation info,
654 List<String> vmOptions, 655 List<String> vmOptions,
655 List<String> sharedOptions, 656 List<String> sharedOptions,
656 List<String> originalArguments, 657 List<String> originalArguments,
657 CommandArtifact artifact) { 658 CommandArtifact artifact) {
658 return <String>[]; 659 return <String>[];
659 } 660 }
660 } 661 }
OLDNEW
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698