Issue 2118883002: [Mac] Add MessagePumpMac callouts to com.apple.hitoolbox.windows.windowfadingmode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2118883002: [Mac] Add MessagePumpMac callouts to com.apple.hitoolbox.windows.windowfadingmode.

Created:
4 years, 5 months ago by Robert Sesek

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Mac] Add MessagePumpMac callouts to com.apple.hitoolbox.windows.windowfadingmode. This allows posted tasks to get pumped during HIToolbox animations, like when closing a menu. TEST=Start playing a video. Open a main menubar menu and then close it. Video playback should be smooth and not pause as the menu animates closed.

Patch Set 1 #

Patch Set 2 : NSUnhighlightMenuRunLoopMode #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -12 lines)			Patch
	M	base/message_loop/message_pump_mac.mm	View	1	1 chunk	+27 lines, -12 lines	0 comments	Download