Fix pixelation of tab borders when device scale changes (abandoned)

chrome/browser/ui/views/tabs/tab.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_
 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_
 
 #include <list>
 #include <memory>
 #include <string>
@@ skipping 15 matching lines @@
 
 class AlertIndicatorButton;
 class TabController;
 
 namespace gfx {
 class Animation;
 class AnimationContainer;
 class LinearAnimation;
 class ThrobAnimation;
 }
+namespace ui {
+class ThemeProvider;
+}
 namespace views {
 class ImageButton;
 class Label;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 //
 //  A View that renders a Tab in a TabStrip.
 //
 ///////////////////////////////////////////////////////////////////////////////
 class Tab : public gfx::AnimationDelegate,
             public views::ButtonListener,
             public views::ContextMenuController,
             public views::MaskedTargeterDelegate,
             public views::View {
  public:
   // The Tab's class name.
   static const char kViewClassName[];
 
+  struct PaintBackgroundParams {

[oshima, 2016/07/13 20:55:28]

can you move this to private & .cc file?

[Greg Levin, 2016/07/15 22:24:48]

Done in Patch #3 ; moved to namespace in Patch #4.

+    const ui::ThemeProvider* tp;
+    views::GlowHoverController* hc;
+    bool is_active;
+    int fill_id;
+    bool has_custom_image;
+    int x_offset;
+    int y_offset;
+    gfx::Size size;
+    SkColor stroke_color;
+  };
+
   Tab(TabController* controller, gfx::AnimationContainer* container);
   ~Tab() override;
 
   TabController* controller() const { return controller_; }
 
   // Used to set/check whether this Tab is being animated closed.
   void set_closing(bool closing) { closing_ = closing; }
   bool closing() const { return closing_; }
 
   // See description above field.
@@ skipping 112 matching lines @@
   friend class TabTest;
   friend class TabStripTest;
   FRIEND_TEST_ALL_PREFIXES(TabStripTest, TabHitTestMaskWhenStacked);
   FRIEND_TEST_ALL_PREFIXES(TabStripTest, TabCloseButtonVisibilityWhenStacked);
 
   // The animation object used to swap the favicon with the sad tab icon.
   class FaviconCrashAnimation;
 
   class TabCloseButton;
   class ThrobberView;
+  class TabImageSource;
 
   // All metadata necessary to uniquely identify a cached image.
   struct ImageCacheEntryMetadata;
 
   // A cached image and the metadata used to generate it.
   struct ImageCacheEntry;
   typedef std::list<ImageCacheEntry> ImageCache;
 
   // gfx::AnimationDelegate:
   void AnimationProgressed(const gfx::Animation* animation) override;
@@ skipping 48 matching lines @@
   void PaintImmersiveTab(gfx::Canvas* canvas);
 
   // Paint various portions of the Tab.
   void PaintTabBackground(gfx::Canvas* canvas);
   void PaintInactiveTabBackground(gfx::Canvas* canvas);
   void PaintTabBackgroundUsingFillId(gfx::Canvas* canvas,
                                      bool is_active,
                                      int fill_id,
                                      bool has_custom_image,
                                      int y_offset);
-  void PaintTabFill(gfx::Canvas* canvas,
-                    gfx::ImageSkia* fill_image,
-                    int x_offset,
-                    int y_offset,
-                    bool is_active);
+  static void PaintTabBackgroundUsingFillId(
+      gfx::Canvas* canvas,
+      const PaintBackgroundParams& params);
+  static void PaintTabFill(gfx::Canvas* canvas,
+                           gfx::ImageSkia* fill_image,
+                           int x_offset,
+                           int y_offset,
+                           const gfx::Size& size,
+                           bool is_active);

[oshima, 2016/07/13 20:55:28]

move private static member function to anonymous namespace in .cc

[Greg Levin, 2016/07/15 22:24:48]

Done.  Moved PaintTabBackgroundUsingFillId() in Patch #4, moved other stuff in
in https://codereview.chromium.org/2150013002/.

 
   // Paints the pinned tab title changed indicator and |favicon_|. |favicon_|
   // may be null. |favicon_draw_bounds| is |favicon_bounds_| adjusted for rtl
   // and clipped to the bounds of the tab.
   void PaintPinnedTabTitleChangedIndicatorAndIcon(
       gfx::Canvas* canvas,
       const gfx::Rect& favicon_draw_bounds);
 
   // Paints the favicon, mirrored for RTL if needed.
   void PaintIcon(gfx::Canvas* canvas);
@@ skipping 32 matching lines @@
   // Recalculates the correct |button_color_| and resets the title, alert
   // indicator, and close button colors if necessary.  This should be called any
   // time the theme or active state may have changed.
   void OnButtonColorMaybeChanged();
 
   // Schedules repaint task for icon.
   void ScheduleIconPaint();
 
   // Computes a path corresponding to the tab's content region inside the outer
   // stroke.
-  void GetFillPath(float scale, SkPath* path) const;
+  static void GetFillPath(float scale, const gfx::Size& size, SkPath* path);
 
   // Computes a path corresponding to the tab's outer border for a given |scale|
   // and stores it in |path|.  If |extend_to_top| is true, the path is extended
   // vertically to the top of the tab bounds.  The caller uses this for Fitts'
   // Law purposes in maximized/fullscreen mode.
-  void GetBorderPath(float scale, bool extend_to_top, SkPath* path) const;
+  static void GetBorderPath(float scale,
+                            const gfx::Size& size,
+                            bool extend_to_top,
+                            SkPath* path);
 
   // Returns the rectangle for the light bar in immersive mode.
   gfx::Rect GetImmersiveBarRect() const;
 
   // Performs a one-time initialization of static resources such as tab images.
   static void InitTabResources();
 
   // Loads the images to be used for the tab background.
   static void LoadTabImages();
 
@@ skipping 77 matching lines @@
   gfx::ImageSkia favicon_;
 
   // As the majority of the tabs are inactive, and painting tabs is slowish,
   // we cache a handful of the inactive tab backgrounds here.
   static ImageCache* image_cache_;
 
   DISALLOW_COPY_AND_ASSIGN(Tab);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_