Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: runtime/vm/isolate.h

Issue 2118813003: Separate mutex for megamorphic cache tables lookup in the background compiler. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ISOLATE_H_ 5 #ifndef VM_ISOLATE_H_
6 #define VM_ISOLATE_H_ 6 #define VM_ISOLATE_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "vm/atomic.h" 10 #include "vm/atomic.h"
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 void set_spawn_state(IsolateSpawnState* value) { spawn_state_ = value; } 275 void set_spawn_state(IsolateSpawnState* value) { spawn_state_ = value; }
276 276
277 Mutex* mutex() const { return mutex_; } 277 Mutex* mutex() const { return mutex_; }
278 Mutex* symbols_mutex() const { return symbols_mutex_; } 278 Mutex* symbols_mutex() const { return symbols_mutex_; }
279 Mutex* type_canonicalization_mutex() const { 279 Mutex* type_canonicalization_mutex() const {
280 return type_canonicalization_mutex_; 280 return type_canonicalization_mutex_;
281 } 281 }
282 Mutex* constant_canonicalization_mutex() const { 282 Mutex* constant_canonicalization_mutex() const {
283 return constant_canonicalization_mutex_; 283 return constant_canonicalization_mutex_;
284 } 284 }
285 Mutex* megamorphic_lookup_mutex() const {
286 return megamorphic_lookup_mutex_;
287 }
285 288
286 Debugger* debugger() const { 289 Debugger* debugger() const {
287 if (!FLAG_support_debugger) { 290 if (!FLAG_support_debugger) {
288 return NULL; 291 return NULL;
289 } 292 }
290 ASSERT(debugger_ != NULL); 293 ASSERT(debugger_ != NULL);
291 return debugger_; 294 return debugger_;
292 } 295 }
293 296
294 void set_single_step(bool value) { single_step_ = value; } 297 void set_single_step(bool value) { single_step_ = value; }
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
710 Debugger* debugger_; 713 Debugger* debugger_;
711 bool resume_request_; 714 bool resume_request_;
712 int64_t last_resume_timestamp_; 715 int64_t last_resume_timestamp_;
713 bool has_compiled_code_; // Can check that no compilation occured. 716 bool has_compiled_code_; // Can check that no compilation occured.
714 Random random_; 717 Random random_;
715 Simulator* simulator_; 718 Simulator* simulator_;
716 Mutex* mutex_; // Protects compiler stats. 719 Mutex* mutex_; // Protects compiler stats.
717 Mutex* symbols_mutex_; // Protects concurrent access to the symbol table. 720 Mutex* symbols_mutex_; // Protects concurrent access to the symbol table.
718 Mutex* type_canonicalization_mutex_; // Protects type canonicalization. 721 Mutex* type_canonicalization_mutex_; // Protects type canonicalization.
719 Mutex* constant_canonicalization_mutex_; // Protects const canonicalization. 722 Mutex* constant_canonicalization_mutex_; // Protects const canonicalization.
723 Mutex* megamorphic_lookup_mutex_; // Protects megamorphic table lookup.
720 MessageHandler* message_handler_; 724 MessageHandler* message_handler_;
721 IsolateSpawnState* spawn_state_; 725 IsolateSpawnState* spawn_state_;
722 bool is_runnable_; 726 bool is_runnable_;
723 Dart_GcPrologueCallback gc_prologue_callback_; 727 Dart_GcPrologueCallback gc_prologue_callback_;
724 Dart_GcEpilogueCallback gc_epilogue_callback_; 728 Dart_GcEpilogueCallback gc_epilogue_callback_;
725 intptr_t defer_finalization_count_; 729 intptr_t defer_finalization_count_;
726 DeoptContext* deopt_context_; 730 DeoptContext* deopt_context_;
727 731
728 bool is_service_isolate_; 732 bool is_service_isolate_;
729 733
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
973 intptr_t* spawn_count_; 977 intptr_t* spawn_count_;
974 978
975 Dart_IsolateFlags isolate_flags_; 979 Dart_IsolateFlags isolate_flags_;
976 bool paused_; 980 bool paused_;
977 bool errors_are_fatal_; 981 bool errors_are_fatal_;
978 }; 982 };
979 983
980 } // namespace dart 984 } // namespace dart
981 985
982 #endif // VM_ISOLATE_H_ 986 #endif // VM_ISOLATE_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698