Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: runtime/vm/megamorphic_cache_table.cc

Issue 2118813003: Separate mutex for megamorphic cache tables lookup in the background compiler. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« runtime/vm/isolate.cc ('K') | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/megamorphic_cache_table.h" 5 #include "vm/megamorphic_cache_table.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 #include "vm/object.h" 8 #include "vm/object.h"
9 #include "vm/object_store.h" 9 #include "vm/object_store.h"
10 #include "vm/stub_code.h" 10 #include "vm/stub_code.h"
11 #include "vm/symbols.h" 11 #include "vm/symbols.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 RawMegamorphicCache* MegamorphicCacheTable::Lookup(Isolate* isolate, 15 RawMegamorphicCache* MegamorphicCacheTable::Lookup(Isolate* isolate,
16 const String& name, 16 const String& name,
17 const Array& descriptor) { 17 const Array& descriptor) {
18 // Multiple compilation threads could access this lookup. 18 // Multiple compilation threads could access this lookup.
19 SafepointMutexLocker ml(isolate->mutex()); 19 SafepointMutexLocker ml(isolate->lookup_mutex());
20 ASSERT(name.IsSymbol()); 20 ASSERT(name.IsSymbol());
21 // TODO(rmacnak): ASSERT(descriptor.IsCanonical()); 21 // TODO(rmacnak): ASSERT(descriptor.IsCanonical());
22 22
23 // TODO(rmacnak): Make a proper hashtable a la symbol table. 23 // TODO(rmacnak): Make a proper hashtable a la symbol table.
24 GrowableObjectArray& table = GrowableObjectArray::Handle( 24 GrowableObjectArray& table = GrowableObjectArray::Handle(
25 isolate->object_store()->megamorphic_cache_table()); 25 isolate->object_store()->megamorphic_cache_table());
26 MegamorphicCache& cache = MegamorphicCache::Handle(); 26 MegamorphicCache& cache = MegamorphicCache::Handle();
27 if (table.IsNull()) { 27 if (table.IsNull()) {
28 table = GrowableObjectArray::New(Heap::kOld); 28 table = GrowableObjectArray::New(Heap::kOld);
29 isolate->object_store()->set_megamorphic_cache_table(table); 29 isolate->object_store()->set_megamorphic_cache_table(table);
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 cumulative_entries += probe_counts[i]; 145 cumulative_entries += probe_counts[i];
146 OS::Print("Megamorphic probe %" Pd ": %" Pd " (%lf)\n", 146 OS::Print("Megamorphic probe %" Pd ": %" Pd " (%lf)\n",
147 i, probe_counts[i], 147 i, probe_counts[i],
148 static_cast<double>(cumulative_entries) / 148 static_cast<double>(cumulative_entries) /
149 static_cast<double>(entry_count)); 149 static_cast<double>(entry_count));
150 } 150 }
151 delete[] probe_counts; 151 delete[] probe_counts;
152 } 152 }
153 153
154 } // namespace dart 154 } // namespace dart
OLDNEW
« runtime/vm/isolate.cc ('K') | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698