Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2118793002: [turbofan] Broaden checkpoint elimination on returns. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Broaden checkpoint elimination on returns. This makes the elimination of checkpoints flowing effect-wise into nodes having the {Return} operator more permissive. We can cut out checkpoints even when they are not wholly owned by the return. This also alleviates a problem where TCO no longer applies. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-624747 BUG=chromium:624747 Committed: https://crrev.com/a757a62bf5106086250e61eb3a17db888c8a37e3 Cr-Commit-Position: refs/heads/master@{#37480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M src/compiler/checkpoint-elimination.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-624747.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-01 13:26:34 UTC) #2
Jarin
Neat solution! lgtm.
4 years, 5 months ago (2016-07-01 13:41:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118793002/1
4 years, 5 months ago (2016-07-01 13:49:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 13:51:59 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 13:53:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a757a62bf5106086250e61eb3a17db888c8a37e3
Cr-Commit-Position: refs/heads/master@{#37480}

Powered by Google App Engine
This is Rietveld 408576698