Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2118763002: Revert "Handle fields with initializers in constant constructors." (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Handle fields with initializers in constant constructors." This reverts commit 95e6dde715e2164ba74a71d2f9924dd36f3d2266. BUG= Committed: https://github.com/dart-lang/sdk/commit/fa8f7d20f3848db9676e8d1af30ceaefa1ccb21d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -129 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 15 chunks +37 lines, -58 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +5 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +13 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +5 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +1 line, -5 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
4 years, 5 months ago (2016-07-01 09:10:10 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as fa8f7d20f3848db9676e8d1af30ceaefa1ccb21d (presubmit successful).
4 years, 5 months ago (2016-07-01 09:25:56 UTC) #4
Harry Terkelsen
4 years, 5 months ago (2016-07-01 15:45:58 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698