Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: src/gpu/vk/GrVkGpu.cpp

Issue 2118733005: Fix vulkan image sampling (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: remove debug Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/vk/GrVkGpuCommandBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/vk/GrVkGpu.cpp
diff --git a/src/gpu/vk/GrVkGpu.cpp b/src/gpu/vk/GrVkGpu.cpp
index c1cec9d96fa7ea77fc4d829566b56dd34bd6e0c0..e907d8d87860374ca2dd05a18b8ebccba01299a4 100644
--- a/src/gpu/vk/GrVkGpu.cpp
+++ b/src/gpu/vk/GrVkGpu.cpp
@@ -784,7 +784,8 @@ void GrVkGpu::generateMipmap(GrVkTexture* tex) const {
// determine if we can blit to and from this format
const GrVkCaps& caps = this->vkCaps();
if (!caps.configCanBeDstofBlit(tex->config(), false) ||
- !caps.configCanBeSrcofBlit(tex->config(), false)) {
+ !caps.configCanBeSrcofBlit(tex->config(), false) ||
+ !caps.mipMapSupport()) {
return;
}
egdaniel 2016/07/01 20:20:22 On Nvidia, there seems to be a driver bug in blitt
bsalomon 2016/07/02 00:50:12 I leave it to you whether you want to workaround t
jvanverth1 2016/07/06 15:19:42 I'm fine with landing this as is, and creating a s
« no previous file with comments | « no previous file | src/gpu/vk/GrVkGpuCommandBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698