Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2118733003: [wasm] Dont ship by default. (Closed)

Created:
4 years, 5 months ago by titzer
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Dont ship by default. R=mstarzinger@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/ac4fdca6c9f9539b51d2e531f4e3aa48eb770162 Cr-Commit-Position: refs/heads/master@{#37478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/wasm/wasm-js.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A + test/mjsunit/wasm/no-wasm-by-default.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 5 months ago (2016-07-01 11:11:56 UTC) #1
Michael Starzinger
LGTM. Thanks!
4 years, 5 months ago (2016-07-01 11:13:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118733003/1
4 years, 5 months ago (2016-07-01 11:15:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 11:35:42 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ac4fdca6c9f9539b51d2e531f4e3aa48eb770162 Cr-Commit-Position: refs/heads/master@{#37478}
4 years, 5 months ago (2016-07-01 11:37:58 UTC) #7
bradn
4 years, 5 months ago (2016-07-01 12:41:28 UTC) #9
Message was sent while issue was closed.
++LGTM!!

Check got lost when I moved the rest of it out of wasm-js.cc

Sorry for churn. Thanks for fixing!

Powered by Google App Engine
This is Rietveld 408576698