Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2118653004: [builtins] make AsyncFunction constructor a subclass of Function (Closed)

Created:
4 years, 5 months ago by caitp (gmail)
Modified:
4 years, 5 months ago
Reviewers:
jwolfe, Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] make AsyncFunction constructor a subclass of Function Corrects a small problem with the current implementation of the AsyncFunction constructor. See https://tc39.github.io/ecmascript-asyncawait/#async-function-constructor for details. BUG=v8:4483 R=littledan@chromium.org, adamk@chromium.org, jwolfe@igalia.com Committed: https://crrev.com/cd9e5f30ea58e8e92ed2b2ee7c608b905b91d725 Cr-Commit-Position: refs/heads/master@{#37484}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : Don't redundantly call set_prototype_or_initial_map() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/async-await-basic.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caitp (gmail)
PTAL --- small spec compliance issue that needs to be addressed before the feature is ...
4 years, 5 months ago (2016-07-01 21:44:14 UTC) #1
Dan Ehrenberg
On 2016/07/01 21:44:14, caitp wrote: > PTAL --- small spec compliance issue that needs to ...
4 years, 5 months ago (2016-07-01 22:08:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118653004/40001
4 years, 5 months ago (2016-07-01 22:34:31 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-01 22:50:13 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 22:52:52 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cd9e5f30ea58e8e92ed2b2ee7c608b905b91d725
Cr-Commit-Position: refs/heads/master@{#37484}

Powered by Google App Engine
This is Rietveld 408576698