Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 2118653003: clang-plugin: Remove system include from auto_raw_pointer test. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang-plugin: Remove system include from auto_raw_pointer test. This patch removes a system include from a test that is meant to be standalone. R=thakis@chromium.org, dcheng Committed: https://chromium.googlesource.com/chromium/src/+/35a900e3ee8f2bf93654621eb24914c5eb07fd95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M tools/clang/plugins/tests/auto_raw_pointer.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M tools/clang/plugins/tests/auto_raw_pointer.txt View 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-07-01 20:48:06 UTC) #1
Nico
lgtm Consider `git cl land` since no main waterfall bot uses this :-)
4 years, 5 months ago (2016-07-01 20:51:33 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/35a900e3ee8f2bf93654621eb24914c5eb07fd95 Cr-Commit-Position: refs/heads/master@{#403527}
4 years, 5 months ago (2016-07-01 21:04:20 UTC) #4
vmpstr
Committed patchset #1 (id:1) manually as 35a900e3ee8f2bf93654621eb24914c5eb07fd95 (presubmit successful).
4 years, 5 months ago (2016-07-01 21:05:43 UTC) #6
vmpstr
4 years, 5 months ago (2016-07-01 21:09:09 UTC) #7
Message was sent while issue was closed.
On 2016/07/01 20:51:33, Nico wrote:
> lgtm
> 
> Consider `git cl land` since no main waterfall bot uses this :-)

Done and done. Thanks!

Powered by Google App Engine
This is Rietveld 408576698