Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: sdk/lib/web_audio/dart2js/web_audio_dart2js.dart

Issue 2118633002: Don't use => on void functions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sdk/lib/web_audio/dartium/web_audio_dartium.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * High-fidelity audio programming in the browser. 2 * High-fidelity audio programming in the browser.
3 */ 3 */
4 library dart.dom.web_audio; 4 library dart.dom.web_audio;
5 5
6 import 'dart:async'; 6 import 'dart:async';
7 import 'dart:collection'; 7 import 'dart:collection';
8 import 'dart:_internal'; 8 import 'dart:_internal';
9 import 'dart:html'; 9 import 'dart:html';
10 import 'dart:html_common'; 10 import 'dart:html_common';
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 @DocsEditable() 469 @DocsEditable()
470 final int numberOfInputs; 470 final int numberOfInputs;
471 471
472 @DomName('AudioNode.numberOfOutputs') 472 @DomName('AudioNode.numberOfOutputs')
473 @DocsEditable() 473 @DocsEditable()
474 final int numberOfOutputs; 474 final int numberOfOutputs;
475 475
476 @JSName('connect') 476 @JSName('connect')
477 @DomName('AudioNode.connect') 477 @DomName('AudioNode.connect')
478 @DocsEditable() 478 @DocsEditable()
479 void _connect(destination, [int output, int input]) native; 479 void _connect(destination, [int output, int input]) native;
floitsch 2016/07/08 18:02:32 Fwiw: the "_connect" return type is probably not c
sra1 2016/07/08 18:12:03 The return type of native functions is assumed to
floitsch 2016/07/11 12:20:04 I don't know how to change this. This part seems t
480 480
481 @DomName('AudioNode.disconnect') 481 @DomName('AudioNode.disconnect')
482 @DocsEditable() 482 @DocsEditable()
483 void disconnect([destination_OR_output, int output, int input]) native; 483 void disconnect([destination_OR_output, int output, int input]) native;
484 484
485 @DomName('AudioNode.connect') 485 @DomName('AudioNode.connect')
486 void connectNode(AudioNode destination, [int output = 0, int input = 0]) => 486 void connectNode(AudioNode destination, [int output = 0, int input = 0]) {
487 _connect(destination, output, input); 487 _connect(destination, output, input);
488 }
488 489
489 @DomName('AudioNode.connect') 490 @DomName('AudioNode.connect')
490 void connectParam(AudioParam destination, [int output = 0]) => 491 void connectParam(AudioParam destination, [int output = 0]) {
491 _connect(destination, output); 492 _connect(destination, output);
493 }
492 } 494 }
493 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 495 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
494 // for details. All rights reserved. Use of this source code is governed by a 496 // for details. All rights reserved. Use of this source code is governed by a
495 // BSD-style license that can be found in the LICENSE file. 497 // BSD-style license that can be found in the LICENSE file.
496 498
497 499
498 @DocsEditable() 500 @DocsEditable()
499 @DomName('AudioParam') 501 @DomName('AudioParam')
500 // https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioPa ram 502 // https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioPa ram
501 @Experimental() 503 @Experimental()
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
1045 factory WaveShaperNode._() { throw new UnsupportedError("Not supported"); } 1047 factory WaveShaperNode._() { throw new UnsupportedError("Not supported"); }
1046 1048
1047 @DomName('WaveShaperNode.curve') 1049 @DomName('WaveShaperNode.curve')
1048 @DocsEditable() 1050 @DocsEditable()
1049 Float32List curve; 1051 Float32List curve;
1050 1052
1051 @DomName('WaveShaperNode.oversample') 1053 @DomName('WaveShaperNode.oversample')
1052 @DocsEditable() 1054 @DocsEditable()
1053 String oversample; 1055 String oversample;
1054 } 1056 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/web_audio/dartium/web_audio_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698