Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 211863003: Second part of porting Chrome Ash to Windows 7 (Closed)

Created:
6 years, 9 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 9 months ago
Reviewers:
zturner, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Second part of porting Chrome Ash to Windows 7 This CL adds more meat to all the interfaces and gets ChromeAppViewAsh to work all the Way to the Run() method, including the DirectX initialization. First part with rationale: https://codereview.chromium.org/199843004/ NOTRY=true BUG=356475 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259984

Patch Set 1 : remove leftovers #

Patch Set 2 : msg loop #

Total comments: 7

Patch Set 3 : spaces again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -53 lines) Patch
M win8/metro_driver/chrome_app_view_ash.cc View 6 chunks +23 lines, -19 lines 0 comments Download
M win8/metro_driver/direct3d_helper.cc View 3 chunks +38 lines, -9 lines 0 comments Download
M win8/metro_driver/metro_driver_win7.cc View 1 2 20 chunks +167 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cpu_(ooo_6.6-7.5)
Second part of the win7 port to ash. The basic machinery in the metro process ...
6 years, 9 months ago (2014-03-26 19:22:53 UTC) #1
scottmg
LGTM https://codereview.chromium.org/211863003/diff/30002/win8/metro_driver/metro_driver_win7.cc File win8/metro_driver/metro_driver_win7.cc (right): https://codereview.chromium.org/211863003/diff/30002/win8/metro_driver/metro_driver_win7.cc#newcode160 win8/metro_driver/metro_driver_win7.cc:160: winui::Core::IDispatchedHandler *agileCallback, nit; random * bindings here
6 years, 9 months ago (2014-03-26 19:56:54 UTC) #2
zturner
lgtm https://codereview.chromium.org/211863003/diff/30002/win8/metro_driver/metro_driver_win7.cc File win8/metro_driver/metro_driver_win7.cc (right): https://codereview.chromium.org/211863003/diff/30002/win8/metro_driver/metro_driver_win7.cc#newcode122 win8/metro_driver/metro_driver_win7.cc:122: // ICoreApplication ICoreApplicationView nit: Empty spaces at end ...
6 years, 9 months ago (2014-03-27 00:49:49 UTC) #3
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 9 months ago (2014-03-27 01:22:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/211863003/30002
6 years, 9 months ago (2014-03-27 01:24:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 01:49:41 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57739
6 years, 9 months ago (2014-03-27 01:49:42 UTC) #7
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 9 months ago (2014-03-27 21:00:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/211863003/80001
6 years, 9 months ago (2014-03-27 21:04:05 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 21:09:05 UTC) #10
Message was sent while issue was closed.
Change committed as 259984

Powered by Google App Engine
This is Rietveld 408576698