Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2118613002: Add debugging output for visual rects in PaintController. (Closed)

Created:
4 years, 5 months ago by chrishtr
Modified:
4 years, 5 months ago
Reviewers:
wkorman
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add debugging output for visual rects in PaintController. Committed: https://crrev.com/5ab8a36c6719c66a8ab2f1dd7d6c1133c1f78fba Cr-Commit-Position: refs/heads/master@{#403349}

Patch Set 1 #

Total comments: 2

Patch Set 2 : none #

Patch Set 3 : none #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp View 1 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 2 chunks +5 lines, -1 line 1 comment Download

Messages

Total messages: 12 (5 generated)
chrishtr
4 years, 5 months ago (2016-06-30 22:22:51 UTC) #3
wkorman
lgtm https://codereview.chromium.org/2118613002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp (right): https://codereview.chromium.org/2118613002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp#newcode510 third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:510: stringBuilder.append(WTF::String::format(", visualRect: [%d,%d,%d,%d]", Can we tweak to match ...
4 years, 5 months ago (2016-06-30 22:25:56 UTC) #4
chrishtr
https://codereview.chromium.org/2118613002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp (right): https://codereview.chromium.org/2118613002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp#newcode510 third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:510: stringBuilder.append(WTF::String::format(", visualRect: [%d,%d,%d,%d]", On 2016/06/30 at 22:25:55, wkorman wrote: ...
4 years, 5 months ago (2016-06-30 22:29:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2118613002/40001
4 years, 5 months ago (2016-06-30 22:30:22 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 23:51:17 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5ab8a36c6719c66a8ab2f1dd7d6c1133c1f78fba Cr-Commit-Position: refs/heads/master@{#403349}
4 years, 5 months ago (2016-06-30 23:52:34 UTC) #11
wkorman
4 years, 5 months ago (2016-07-01 19:04:06 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/2118613002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
(right):

https://codereview.chromium.org/2118613002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:47:
stringBuilder.append(WTF::String::format(", rect: [%f,%f %fx%f]",
Can remove WTF:: here in two places, also here and in PaintController, can
alternatively do:

rect: [%s]", m_picture->ToString().ascii().data())

Is that better? I'm not sure. I've grown to deeply loathe ascii().data().

https://codereview.chromium.org/2118613002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(right):

https://codereview.chromium.org/2118613002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:509:
IntRect visualRect = list.visualRect(i);
I think that this can/will lead to a failed DCHECK assert with i >= visual rect
vector size, in this debug block:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graph...

Powered by Google App Engine
This is Rietveld 408576698